monotone-devel
[Top][All Lists]
Advanced

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

Re: [Monotone-devel] overwriteable and negatable options


From: Timothy Brownawell
Subject: Re: [Monotone-devel] overwriteable and negatable options
Date: Mon, 21 Jun 2010 20:32:31 -0500
User-agent: Mozilla/5.0 (X11; U; Linux x86_64; en-US; rv:1.9.1.9) Gecko/20100515 Icedove/3.0.4

On 06/21/2010 02:43 PM, Stephen Leake wrote:
In the particular case of dates, I don't think we need
--no-format-dates; that's the same as --default-date-format.

--no-format-dates tells it not to do any formatting; --default-date-format tells it to ask the hook what format to use. But the hook and any default options are probably being defined by the same person, so --default-date-format is probably silly and it can go away.

How many other options actually have a group reset, as opposed to a
single reset? I don't see any in options.hh, but maybe I missed
something.

--verbosity and friends kinda-sorta do, but that probably doesn't count (hm, this actually doesn't need a resetter, it would do the same thing as "--verbosity=0").

--bind belongs with --no-transport-auth and --stdio in a way that a group reset *might* make sense, except that --no-transport-auth and --stdio are really only for self-invocation (and probably should be hidden).

--message and --message-file are mutually exclusive, so they probably shouldn't have a common reset.

--conflicts-file, --resolve-conflicts, and --resolve-conflicts-file look like they go together.... looks like --conflicts-file and --resolve-conflicts-file really ought to be the same option, and --resolve-conflicts/--resolve-conflicts-file would make sense having a common reset option.

This last one looks like the *only* case where we really need a group of options to get reset together. And I suppose even this could be recast as a pair of somewhat-independent options, where --resolve-conflicts/--no-resolve-conflicts turn conflict handling on or off and --resolve-conflicts-file tells it to use something other than the default location if conflict handling is turned on (and of course also switches handling to on, since doing otherwise would be odd). Really this would just take a bit of tweaking in the descriptions:
  --resolve-conflicts             resolve conflicts interactively (???)
  --resolve-conflicts-file <arg>  use the given file instead of _MTN/conflicts
>                                   to resolve conflicts
(right now it says:
  --resolve-conflicts             use _MTN/conflicts to resolve conflicts
  --resolve-conflicts-file <arg>  use file to resolve conflicts
).

So [0] (current format) is actually workable, and I think I can set it to I() on startup if you try to give a resetter for an optset that has more than one flag.

--
Timothy

Free public monotone hosting: http://mtn-host.prjek.net



reply via email to

[Prev in Thread] Current Thread [Next in Thread]