[Monotone-devel] Issue 131 - Mingw mtn ssh-agent support does not work with Cygwin ssh-agent (monotone)

[code]

Hello,

A new issue has been created and assigned
to you:

131 - Mingw mtn ssh-agent support does not work with Cygwin ssh-agent
Project: monotone
Status: New
Reported by: Stephen Leake
Labels:
 Priority:Low
 Type:wish

Description:

Steps to reproduce the problem:
-------------------------------

1. cmd$ ssh-agent bash
2. bash$ mtn ssh_agent_add

Expected result:
----------------
mtn should add private key to running ssh-agent session

Actual results:
---------------
mtn reports 'no ssh-agent is available'

Output of `mtn version --full`: 1.0dev
-------------------------------

this does work with cygwin mtn and cygwin ssh-agent, and with Debian mtn and 
Debian ssh-agent.

The problem is in win32/ssh_agent_platform.cc. It uses Win32 FindWindow to find 
a running instance of "Pageant", which is the ssh-agent for PuTTY, a popular 
implementation of ssh on Windows.

It should also search for the cygwin ssh-agent parent process, using env vars 
SSH_AUTH_SOCK and SSH_AGENT_PID. This requires Unix sockets, which may not be 
available in MinGW.

--
Issue: https://code.monotone.ca/p/monotone/issues/131/