Re: [Monotone-devel] [Monotone-debian] Bug#665448: Bug#665448: monotone: FTBFS: testsuite failure

[Thomas Moschny]

Francis Russell <address@hidden>:

> On 25/03/12 20:40, Thomas Moschny wrote:
> > this is a mini-patch I recently added to the Fedora package, to
> > build against newer PCRE. It deletes '(?<=\C)' from the list of
> > regular expressions in .mtn-ignore expected to throw an error.
> 
> I wish you'd sent that a few hours earlier :)

Sorry, was out in the garden ;)

> > The man page of PCRE states that \C is not allowed in lookbehind
> > assertions, iff in UTF8 mode. I did not yet verify whether we are
> > actually processing the ignore file patterns in UTF8 mode or not.
> > Anyway, removing that pattern fixed the build for now.
> 
> It looks like the test is dependent on pcre3 recognising that regex as
> invalid as it'll match all the file names otherwise, which is not the
> intended behaviour. Removing it is probably the proper thing to do
> anyway.

Seems \C was completely invalid before 8.21. The changelog states that,
starting with this version, "\C is now supported in lookbehinds and DFA
matching" in non-UTF-8 mode.

The patch is now committed to nvm.

Regards,
Thomas