[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [Nmh-workers] Artificial argv limits.
From: |
David Levine |
Subject: |
Re: [Nmh-workers] Artificial argv limits. |
Date: |
Mon, 26 Nov 2012 21:45:06 -0600 |
Paul F. wrote:
> david wrote:
> > Paul F. wrote:
> >
> > > as for the rest of mh -- it's certainly possible to hit the MAXARGS
> > > limit with other commands (show, for instance), but i suspect the
> > > frequency is much lower, and those, too, can be fixed as needed.
> >
> > I'd vote for nuking these, as well:
> >
> > uip/forw.c: if (mp->numsel >= MAXARGS - i)
> > uip/mshcmds.c: if (mp->numsel > MAXARGS - 1) {
> > uip/show.c: if (mp->numsel > MAXARGS - 2)
>
> i'll take a look, and take a stab at them. they'll need more
> careful review.
All of them load a statically sized array, so it would have
to be changed to dynamically allocated. Maybe it's not
worth the trouble. There'd be an inconsistency between
msh's rmm and the standalone, but I don't think we need to
invest any effort in maintaining msh.
David