[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
[Qemu-block] [PATCH v5 3/6] block/nbd-client: split connection from init
From: |
Vladimir Sementsov-Ogievskiy |
Subject: |
[Qemu-block] [PATCH v5 3/6] block/nbd-client: split connection from initialization |
Date: |
Fri, 1 Feb 2019 16:01:35 +0300 |
Split connection code to reuse it for reconnect.
Signed-off-by: Vladimir Sementsov-Ogievskiy <address@hidden>
Reviewed-by: Eric Blake <address@hidden>
---
block/nbd-client.c | 33 ++++++++++++++++++++++++---------
1 file changed, 24 insertions(+), 9 deletions(-)
diff --git a/block/nbd-client.c b/block/nbd-client.c
index 641666d3bc..a8ce0824c2 100644
--- a/block/nbd-client.c
+++ b/block/nbd-client.c
@@ -1014,13 +1014,13 @@ static QIOChannelSocket
*nbd_establish_connection(SocketAddress *saddr,
return sioc;
}
-int nbd_client_init(BlockDriverState *bs,
- SocketAddress *saddr,
- const char *export,
- QCryptoTLSCreds *tlscreds,
- const char *hostname,
- const char *x_dirty_bitmap,
- Error **errp)
+static int nbd_client_connect(BlockDriverState *bs,
+ SocketAddress *saddr,
+ const char *export,
+ QCryptoTLSCreds *tlscreds,
+ const char *hostname,
+ const char *x_dirty_bitmap,
+ Error **errp)
{
NBDClientSession *client = nbd_get_client_session(bs);
int ret;
@@ -1073,8 +1073,6 @@ int nbd_client_init(BlockDriverState *bs,
bs->supported_zero_flags |= BDRV_REQ_MAY_UNMAP;
}
- qemu_co_mutex_init(&client->send_mutex);
- qemu_co_queue_init(&client->free_sema);
client->sioc = sioc;
if (!client->ioc) {
@@ -1107,3 +1105,20 @@ int nbd_client_init(BlockDriverState *bs,
return ret;
}
}
+
+int nbd_client_init(BlockDriverState *bs,
+ SocketAddress *saddr,
+ const char *export,
+ QCryptoTLSCreds *tlscreds,
+ const char *hostname,
+ const char *x_dirty_bitmap,
+ Error **errp)
+{
+ NBDClientSession *client = nbd_get_client_session(bs);
+
+ qemu_co_mutex_init(&client->send_mutex);
+ qemu_co_queue_init(&client->free_sema);
+
+ return nbd_client_connect(bs, saddr, export, tlscreds, hostname,
+ x_dirty_bitmap, errp);
+}
--
2.18.0
- [Qemu-block] [PATCH v5 0/6] NBD reconnect: prep. refactoring, Vladimir Sementsov-Ogievskiy, 2019/02/01
- [Qemu-block] [PATCH v5 3/6] block/nbd-client: split connection from initialization,
Vladimir Sementsov-Ogievskiy <=
- [Qemu-block] [PATCH v5 1/6] block/nbd-client: split channel errors from export errors, Vladimir Sementsov-Ogievskiy, 2019/02/01
- [Qemu-block] [PATCH v5 4/6] block/nbd-client: fix nbd_reply_chunk_iter_receive, Vladimir Sementsov-Ogievskiy, 2019/02/01
- [Qemu-block] [PATCH v5 2/6] block/nbd: move connection code from block/nbd to block/nbd-client, Vladimir Sementsov-Ogievskiy, 2019/02/01
- [Qemu-block] [PATCH v5 6/6] block/nbd-client: rename read_reply_co to connection_co, Vladimir Sementsov-Ogievskiy, 2019/02/01
- [Qemu-block] [PATCH v5 5/6] block/nbd-client: don't check ioc, Vladimir Sementsov-Ogievskiy, 2019/02/01
- Re: [Qemu-block] [PATCH v5 0/6] NBD reconnect: prep. refactoring, Eric Blake, 2019/02/01