[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [Qemu-block] [PATCH v5 2/6] block/nbd: move connection code from blo
From: |
Eric Blake |
Subject: |
Re: [Qemu-block] [PATCH v5 2/6] block/nbd: move connection code from block/nbd to block/nbd-client |
Date: |
Fri, 1 Feb 2019 15:14:55 -0600 |
User-agent: |
Mozilla/5.0 (X11; Linux x86_64; rv:60.0) Gecko/20100101 Thunderbird/60.4.0 |
On 2/1/19 7:01 AM, Vladimir Sementsov-Ogievskiy wrote:
> Keep all connection code in one file, to be able to implement reconnect
> in further patches.
>
> Signed-off-by: Vladimir Sementsov-Ogievskiy <address@hidden>
> ---
>
> +static QIOChannelSocket *nbd_establish_connection(SocketAddress *saddr,
> + Error **errp)
> +{
> + QIOChannelSocket *sioc;
> + Error *local_err = NULL;
> +
> + sioc = qio_channel_socket_new();
> + qio_channel_set_name(QIO_CHANNEL(sioc), "nbd-client");
> +
> + qio_channel_socket_connect_sync(sioc,
> + saddr,
> + &local_err);
I know it was code motion, but this fits on one line.
Reviewed-by: Eric Blake <address@hidden>
--
Eric Blake, Principal Software Engineer
Red Hat, Inc. +1-919-301-3226
Virtualization: qemu.org | libvirt.org
signature.asc
Description: OpenPGP digital signature
- [Qemu-block] [PATCH v5 0/6] NBD reconnect: prep. refactoring, Vladimir Sementsov-Ogievskiy, 2019/02/01
- [Qemu-block] [PATCH v5 3/6] block/nbd-client: split connection from initialization, Vladimir Sementsov-Ogievskiy, 2019/02/01
- [Qemu-block] [PATCH v5 1/6] block/nbd-client: split channel errors from export errors, Vladimir Sementsov-Ogievskiy, 2019/02/01
- [Qemu-block] [PATCH v5 4/6] block/nbd-client: fix nbd_reply_chunk_iter_receive, Vladimir Sementsov-Ogievskiy, 2019/02/01
- [Qemu-block] [PATCH v5 2/6] block/nbd: move connection code from block/nbd to block/nbd-client, Vladimir Sementsov-Ogievskiy, 2019/02/01
- Re: [Qemu-block] [PATCH v5 2/6] block/nbd: move connection code from block/nbd to block/nbd-client,
Eric Blake <=
- [Qemu-block] [PATCH v5 6/6] block/nbd-client: rename read_reply_co to connection_co, Vladimir Sementsov-Ogievskiy, 2019/02/01
- [Qemu-block] [PATCH v5 5/6] block/nbd-client: don't check ioc, Vladimir Sementsov-Ogievskiy, 2019/02/01
- Re: [Qemu-block] [PATCH v5 0/6] NBD reconnect: prep. refactoring, Eric Blake, 2019/02/01