[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [PATCH 15/21] block: Mark bdrv_child_perm() GRAPH_RDLOCK
|
From: |
Stefan Hajnoczi |
|
Subject: |
Re: [PATCH 15/21] block: Mark bdrv_child_perm() GRAPH_RDLOCK |
|
Date: |
Tue, 22 Aug 2023 15:29:09 -0400 |
On Thu, Aug 17, 2023 at 02:50:14PM +0200, Kevin Wolf wrote:
> This adds GRAPH_RDLOCK annotations to declare that callers of
> bdrv_child_perm() need to hold a reader lock for the graph because
> some implementations access the children list of a node.
>
> The callers of bdrv_child_perm() conveniently already hold the lock.
>
> Signed-off-by: Kevin Wolf <kwolf@redhat.com>
> ---
> include/block/block_int-common.h | 10 +++++-----
> block.c | 11 ++++++-----
> block/copy-before-write.c | 10 +++++-----
> 3 files changed, 16 insertions(+), 15 deletions(-)
Reviewed-by: Stefan Hajnoczi <stefanha@redhat.com>
signature.asc
Description: PGP signature
- Re: [PATCH 09/21] block: Mark bdrv_replace_child_tran() GRAPH_WRLOCK, (continued)
- [PATCH 12/21] block: Mark bdrv_attach_child() GRAPH_WRLOCK, Kevin Wolf, 2023/08/17
- [PATCH 13/21] block: Mark bdrv_parent_perms_conflict() and callers GRAPH_RDLOCK, Kevin Wolf, 2023/08/17
- [PATCH 15/21] block: Mark bdrv_child_perm() GRAPH_RDLOCK, Kevin Wolf, 2023/08/17
- [PATCH 21/21] block: Mark bdrv_add/del_child() and caller GRAPH_WRLOCK, Kevin Wolf, 2023/08/17
- [PATCH 20/21] block: Mark bdrv_unref_child() GRAPH_WRLOCK, Kevin Wolf, 2023/08/17
- [PATCH 16/21] block: Mark bdrv_parent_cb_change_media() GRAPH_RDLOCK, Kevin Wolf, 2023/08/17
- [PATCH 14/21] block: Mark bdrv_get_cumulative_perm() and callers GRAPH_RDLOCK, Kevin Wolf, 2023/08/17