[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [PATCH 21/21] block: Mark bdrv_add/del_child() and caller GRAPH_WRLO
|
From: |
Stefan Hajnoczi |
|
Subject: |
Re: [PATCH 21/21] block: Mark bdrv_add/del_child() and caller GRAPH_WRLOCK |
|
Date: |
Tue, 22 Aug 2023 15:40:50 -0400 |
On Thu, Aug 17, 2023 at 02:50:20PM +0200, Kevin Wolf wrote:
> The functions read the parents list in the generic block layer, so we
> need to hold the graph lock already there. The BlockDriver
> implementations actually modify the graph, so it has to be a writer
> lock.
>
> Signed-off-by: Kevin Wolf <kwolf@redhat.com>
> ---
> include/block/block-global-state.h | 8 +++++---
> include/block/block_int-common.h | 9 +++++----
> block/quorum.c | 23 ++++++-----------------
> blockdev.c | 17 +++++++++++------
> 4 files changed, 27 insertions(+), 30 deletions(-)
Reviewed-by: Stefan Hajnoczi <stefanha@redhat.com>
signature.asc
Description: PGP signature
- Re: [PATCH 12/21] block: Mark bdrv_attach_child() GRAPH_WRLOCK, (continued)
- [PATCH 13/21] block: Mark bdrv_parent_perms_conflict() and callers GRAPH_RDLOCK, Kevin Wolf, 2023/08/17
- [PATCH 15/21] block: Mark bdrv_child_perm() GRAPH_RDLOCK, Kevin Wolf, 2023/08/17
- [PATCH 21/21] block: Mark bdrv_add/del_child() and caller GRAPH_WRLOCK, Kevin Wolf, 2023/08/17
- [PATCH 20/21] block: Mark bdrv_unref_child() GRAPH_WRLOCK, Kevin Wolf, 2023/08/17
- [PATCH 16/21] block: Mark bdrv_parent_cb_change_media() GRAPH_RDLOCK, Kevin Wolf, 2023/08/17
- [PATCH 14/21] block: Mark bdrv_get_cumulative_perm() and callers GRAPH_RDLOCK, Kevin Wolf, 2023/08/17
- Re: [PATCH 00/21] Graph locking part 4 (node management), Stefan Hajnoczi, 2023/08/22