[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
[PATCH v3 08/21] parallels: Add a note about used bitmap in parallels_ch
From: |
Alexander Ivanov |
Subject: |
[PATCH v3 08/21] parallels: Add a note about used bitmap in parallels_check_duplicate() |
Date: |
Fri, 27 Oct 2023 09:46:23 +0200 |
In parallels_check_duplicate() We use a bitmap for duplication detection.
This bitmap is not related to used_bmap field in BDRVParallelsState. Add
a comment about it to avoid confusion.
Signed-off-by: Alexander Ivanov <alexander.ivanov@virtuozzo.com>
---
block/parallels.c | 5 ++++-
1 file changed, 4 insertions(+), 1 deletion(-)
diff --git a/block/parallels.c b/block/parallels.c
index 2ce3e40ce3..481b6992f4 100644
--- a/block/parallels.c
+++ b/block/parallels.c
@@ -839,7 +839,10 @@ parallels_check_duplicate(BlockDriverState *bs,
BdrvCheckResult *res,
bool fixed = false;
/*
- * Create a bitmap of used clusters.
+ * Create a bitmap of used clusters. Please note that this bitmap is not
+ * related to used_bmap field in BDRVParallelsState and is created only for
+ * local usage.
+ *
* If a bit is set, there is a BAT entry pointing to this cluster.
* Loop through the BAT entries, check bits relevant to an entry offset.
* If bit is set, this entry is duplicated. Otherwise set the bit.
--
2.34.1
- [PATCH v3 18/21] parallels: Remove unnecessary data_end field, (continued)
- [PATCH v3 18/21] parallels: Remove unnecessary data_end field, Alexander Ivanov, 2023/10/27
- [PATCH v3 21/21] tests: Add parallels format support to image-fleecing, Alexander Ivanov, 2023/10/27
- [PATCH v3 10/21] parallels: Add dirty bitmaps saving, Alexander Ivanov, 2023/10/27
- [PATCH v3 14/21] parallels: Make a loaded dirty bitmap persistent, Alexander Ivanov, 2023/10/27
- [PATCH v3 17/21] parallels: Check unused clusters in parallels_check_leak(), Alexander Ivanov, 2023/10/27
- [PATCH v3 20/21] tests: Turned on 256, 299, 304 and block-status-cache for parallels format, Alexander Ivanov, 2023/10/27
- [PATCH v3 04/21] parallels: Add parallels_mark_unused() helper, Alexander Ivanov, 2023/10/27
- [PATCH v3 15/21] parallels: Reverse a conditional in parallels_check_leak() to reduce indents, Alexander Ivanov, 2023/10/27
- [PATCH v3 08/21] parallels: Add a note about used bitmap in parallels_check_duplicate(),
Alexander Ivanov <=
- [PATCH v3 19/21] tests: Add parallels images support to test 165, Alexander Ivanov, 2023/10/27
- [PATCH v3 07/21] parallels: Recreate used bitmap in parallels_check_leak(), Alexander Ivanov, 2023/10/27
- [PATCH v3 16/21] parallels: Truncate images on the last used cluster, Alexander Ivanov, 2023/10/27
- [PATCH v3 12/21] parallels: Let image extensions work in RW mode, Alexander Ivanov, 2023/10/27
- [PATCH v3 06/21] parallels: Set data_end value in parallels_check_leak(), Alexander Ivanov, 2023/10/27
- [PATCH v3 11/21] parallels: Mark parallels_inactivate GRAPH_RDLOCK, guard parallels_close, Alexander Ivanov, 2023/10/27