[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
[PATCH v3 12/21] parallels: Let image extensions work in RW mode
From: |
Alexander Ivanov |
Subject: |
[PATCH v3 12/21] parallels: Let image extensions work in RW mode |
Date: |
Fri, 27 Oct 2023 09:46:27 +0200 |
Now we support extensions saving and can let to work with them in
read-write mode.
Signed-off-by: Alexander Ivanov <alexander.ivanov@virtuozzo.com>
---
block/parallels-ext.c | 4 ----
block/parallels.c | 17 ++++-------------
2 files changed, 4 insertions(+), 17 deletions(-)
diff --git a/block/parallels-ext.c b/block/parallels-ext.c
index 0a632a2331..a0de4f1b07 100644
--- a/block/parallels-ext.c
+++ b/block/parallels-ext.c
@@ -177,10 +177,6 @@ static BdrvDirtyBitmap
*parallels_load_bitmap(BlockDriverState *bs,
return NULL;
}
- /* We support format extension only for RO parallels images. */
- assert(!(bs->open_flags & BDRV_O_RDWR));
- bdrv_dirty_bitmap_set_readonly(bitmap, true);
-
return bitmap;
}
diff --git a/block/parallels.c b/block/parallels.c
index 4c2cb09e43..0a2956b45f 100644
--- a/block/parallels.c
+++ b/block/parallels.c
@@ -1374,19 +1374,10 @@ static int parallels_open(BlockDriverState *bs, QDict
*options, int flags,
}
if (ph.ext_off) {
- if (flags & BDRV_O_RDWR) {
- /*
- * It's unsafe to open image RW if there is an extension (as we
- * don't support it). But parallels driver in QEMU historically
- * ignores the extension, so print warning and don't care.
- */
- warn_report("Format Extension ignored in RW mode");
- } else {
- ret = parallels_read_format_extension(
- bs, le64_to_cpu(ph.ext_off) << BDRV_SECTOR_BITS, errp);
- if (ret < 0) {
- goto fail;
- }
+ ret = parallels_read_format_extension(
+ bs, le64_to_cpu(ph.ext_off) << BDRV_SECTOR_BITS, errp);
+ if (ret < 0) {
+ goto fail;
}
}
--
2.34.1
- [PATCH v3 10/21] parallels: Add dirty bitmaps saving, (continued)
- [PATCH v3 10/21] parallels: Add dirty bitmaps saving, Alexander Ivanov, 2023/10/27
- [PATCH v3 14/21] parallels: Make a loaded dirty bitmap persistent, Alexander Ivanov, 2023/10/27
- [PATCH v3 17/21] parallels: Check unused clusters in parallels_check_leak(), Alexander Ivanov, 2023/10/27
- [PATCH v3 20/21] tests: Turned on 256, 299, 304 and block-status-cache for parallels format, Alexander Ivanov, 2023/10/27
- [PATCH v3 04/21] parallels: Add parallels_mark_unused() helper, Alexander Ivanov, 2023/10/27
- [PATCH v3 15/21] parallels: Reverse a conditional in parallels_check_leak() to reduce indents, Alexander Ivanov, 2023/10/27
- [PATCH v3 08/21] parallels: Add a note about used bitmap in parallels_check_duplicate(), Alexander Ivanov, 2023/10/27
- [PATCH v3 19/21] tests: Add parallels images support to test 165, Alexander Ivanov, 2023/10/27
- [PATCH v3 07/21] parallels: Recreate used bitmap in parallels_check_leak(), Alexander Ivanov, 2023/10/27
- [PATCH v3 16/21] parallels: Truncate images on the last used cluster, Alexander Ivanov, 2023/10/27
- [PATCH v3 12/21] parallels: Let image extensions work in RW mode,
Alexander Ivanov <=
- [PATCH v3 06/21] parallels: Set data_end value in parallels_check_leak(), Alexander Ivanov, 2023/10/27
- [PATCH v3 11/21] parallels: Mark parallels_inactivate GRAPH_RDLOCK, guard parallels_close, Alexander Ivanov, 2023/10/27