Re: [Qemu-devel] [PATCH v2] target/arm: Convert ARM_TBFLAG_* to FIELDs

[Peter Maydell]

On Tue, 18 Dec 2018 at 16:43, Richard Henderson
<address@hidden> wrote:
>
> Use "register" TBFLAG_ANY to indicate shared state between
> A32 and A64, and "registers" TBFLAG_A32 & TBFLAG_A64 for
> fields that are specific to the given cpu state.
>
> Move ARM_TBFLAG_BE to shared state, instead of its current
> placement within "Bit usage when in AArch32 state".

>      if (arm_cpu_data_is_big_endian(env)) {
> -        flags |= ARM_TBFLAG_BE_DATA_MASK;
> +        flags = FIELD_DP32(flags, TBFLAG_ANY, BE, 1);
>      }

Why did you rename this flag from "BE_DATA" to "BE" ? I think
the distinction is important -- the flag tells us only about
the endianness of the d-side, not the i-side. It also matches
up with the name of the function we're using to determine whether
the flag should be set, and with the name of the field in
the DisasContext struct which we populate from the flag.

Otherwise the patch looks good, so if you agree I'll apply
it to target-arm.next with the flag renamed back to BE_DATA.

thanks
-- PMM