Re: [Qemu-devel] [PULL v2 00/44] MIPS pull request for December 2018 - v2

[Peter Maydell]

On Mon, 31 Dec 2018 at 14:56, Aleksandar Markovic
<address@hidden> wrote:
>
> From: Aleksandar Markovic <address@hidden>
>
> The following changes since commit 9b2e891ec5ccdb4a7d583b77988848282606fdea:
>
>   Merge remote-tracking branch 'remotes/marcel/tags/rdma-pull-request' into 
> staging (2018-12-22 11:25:31 +0000)
>
> are available in the git repository at:
>
>   https://github.com/AMarkovic/qemu tags/mips-queue-dec-2018-v2
>
> for you to fetch changes up to 96446398f47b70cf0998412314730709570e08c5:
>
>   tests/tcg: mips: Test R5900 three-operand MADDU1 (2018-12-31 15:47:28 +0100)
>
> ----------------------------------------------------------------
>
> MIPS queue for December 2018 - v2
>
>
>   - this queue contains various amendments to MIPS code
>   - there are three checkpatch warnings that should be ingnored
>     in given circumstances
>   - most of the patches are not yet visible/noticeable to the end
>     user, just a single note related to Paul's patch will be added
>     to ChangeLog
>
> v1->v2:
>
>   - added three patches that were meanwhile tested better
>

Hi; I'm afraid this doesn't build on all my test hosts:

target/mips/translate.c: In function ‘gen_mxu_Q8MAX_Q8MIN’:
target/mips/translate.c:25092:9: error: ‘for’ loop initial
declarations are only allowed in C99 mode
         for (int i = 2; i >= 0; i--) {
         ^
target/mips/translate.c:25092:9: note: use option -std=c99 or
-std=gnu99 to compile your code
target/mips/translate.c:25129:9: error: ‘for’ loop initial
declarations are only allowed in C99 mode
         for (int i = 2; i >= 0; i--) {
         ^

(This probably only shows up on builds with older versions
of gcc which don't default to c99.)

We don't use variable-declaration-in-for-loop.

thanks
-- PMM