Re: [Qemu-devel] [PULL 24/37] qtest: Add set_irq_in command to set IRQ/GPIO level

[Peter Maydell]

On Wed, 9 Jan 2019 at 05:59, Matthew Ogilvie <address@hidden> wrote:
>
> On Mon, Jan 07, 2019 at 04:31:04PM +0000, Peter Maydell wrote:
> > From: Steffen Görtz <address@hidden>
> >
> > Adds a new qtest command "set_irq_in" which allows
> > to set qemu gpio lines to a given level.
> >
> > Based on https://lists.gnu.org/archive/html/qemu-devel/2012-12/msg02363.html
> > which never got merged.
> >
> > Signed-off-by: Steffen Görtz <address@hidden>
> > Reviewed-by: Stefan Hajnoczi <address@hidden>
> > Reviewed-by: Thomas Huth <address@hidden>
> > Reviewed-by: Laurent Vivier <address@hidden>
> > Signed-off-by: Stefan Hajnoczi <address@hidden>
> > Message-id: address@hidden
> > Originally-by: Matthew Ogilvie <address@hidden>
>
> It is kind of interesting to see a part of my old thread(s)
> resurrected, even if it isn't the part I was actually interested
> in.
>
> Note that my miniinfo email account no longer exists, but I
> can still be reached at address@hidden if desired.
>
> Regarding the patch, I haven't kept up with changes to qemu
> well enough to really have a useful opinion, although superficially
> it looks good.  Perhaps it would make sense to include both
> my old and new email addresses in the sign-off section, to both
> tie it to the old threads and make it easier to reach me
> if someone wants to contact me?  (But I'm not sure of a "clean"
> way to do so, and it is probably low priority.  Perhaps this
> current email is good enough?)

Thanks for the followup. Unfortunately the commit is already
in master so we can't tweak the commit message at this point.
That shouldn't matter much, people don't often fish emails out
of old commit message logs to email anyway :-)

thanks
-- PMM