Re: [Qemu-devel] [RFC PATCH v2 24/37] build: convert sound.mak to Kconfig

[Thomas Huth]

On 2019-01-16 14:48, Thomas Huth wrote:
> On 2019-01-15 15:10, Yang Zhong wrote:
>> From: Paolo Bonzini <address@hidden>
>>
>> There is really nothing special in these devices; they are just
>> ISA devices.  Instead of including them for each target,
>> set CONFIG_ISA to true, and make the devices default to present
>> whenever ISA is available.  More conversion of ISA devices will
>> follow.
> [...]
>> diff --git a/default-configs/ppc-softmmu.mak 
>> b/default-configs/ppc-softmmu.mak
>> index 301cc83279..c7003e4284 100644
>> --- a/default-configs/ppc-softmmu.mak
>> +++ b/default-configs/ppc-softmmu.mak
>> @@ -1,8 +1,8 @@
>>  # Default configuration for ppc-softmmu
>>  
>> -include sound.mak
>>  include usb.mak
>>  CONFIG_PCI=y
>> +ONFIG_ISA=y
> 
> Typo: CONFIG_ISA please

Or should it even be CONFIG_ISA_BUS ? At least that's the name of the
switch that you use in the other patches ...

 Thomas