Re: [Qemu-devel] [RFC PATCH v2 26/37] scsi: express dependencies with Kconfig

[Paolo Bonzini]

On 16/01/19 12:50, Thomas Huth wrote:
>> From: Paolo Bonzini <address@hidden>
>>
>> This lets you disable SCSI altogether with "CONFIG_SCSI=n".
> Sorry for my ignorant question, but: Can we really disable SCSI if the
> Kconfig files use "select SCSI" all over the place? I'd rather expect
> that "CONFIG_SCSI=n" only works if we only use "depends on SCSI" everywhere?

Right.  It would work if the controllers depended on SCSI, but you can
say instead "this automatically removes the SCSI subsystem from the
binary altogether if no controllers are selected".  Same for I2C, etc.

Paolo

> I'm fine if we use select SCSI in this patch, but maybe the commit
> message should be tweaked in case you can not really disable SCSI like
> this anymore?