Re: [Qemu-devel] [PATCH v4 5/5] optionrom/pvh: load initrd from fw_cfg

[Stefano Garzarella]

On Thu, Jan 17, 2019 at 03:37:24PM +0100, Paolo Bonzini wrote:
> On 17/01/19 15:33, Liam Merwick wrote:
> > #    pc-bios/optionrom/pvh.bin
> > #    pc-bios/optionrom/pvh.img
> > #    pc-bios/optionrom/pvh.raw

Thanks Liam!

> 
> pvh.bin should not be ignored.

I committed pc-bios/pvh.bin, but I think we should ignore the
pc-bios/optionrom/pvh.bin like for the other optionroms (eg.
pc-bios/optionrom/linuxboot_dma.bin is present in .gitignore)

What do you think if I add the following at patch 3/5?

diff --git a/.gitignore b/.gitignore
index 0430257313..321095bf1a 100644
--- a/.gitignore
+++ b/.gitignore
@@ -103,6 +103,10 @@
 /pc-bios/optionrom/linuxboot_dma.bin
 /pc-bios/optionrom/linuxboot_dma.raw
 /pc-bios/optionrom/linuxboot_dma.img
+/pc-bios/optionrom/pvh.asm
+/pc-bios/optionrom/pvh.bin
+/pc-bios/optionrom/pvh.raw
+/pc-bios/optionrom/pvh.img
 /pc-bios/optionrom/multiboot.asm
 /pc-bios/optionrom/multiboot.bin
 /pc-bios/optionrom/multiboot.raw

Thanks,
Stefano