Re: [Qemu-devel] [PATCH v4 5/5] optionrom/pvh: load initrd from fw_cfg

[Stefano Garzarella]

On Thu, Jan 17, 2019 at 02:52:25PM +0000, Liam Merwick wrote:
> 
> 
> On 17/01/2019 14:37, Paolo Bonzini wrote:
> > On 17/01/19 15:33, Liam Merwick wrote:
> > > #    pc-bios/optionrom/pvh.bin
> > > #    pc-bios/optionrom/pvh.img
> > > #    pc-bios/optionrom/pvh.raw
> > 
> > pvh.bin should not be ignored.
> > 
> 
> That's part of what I didn't quite understand.
> pc-bios/optionrom/linuxboot.bin (and the other binaries in the 'build-all'
> target in pc-bios/optionrom/Makefile) are in .gitignore.
> 
> Also, should pvh.bin be added to BLOBS in Makefile like those files?

Yes, indeed I added pvh.bin to BLOBS in patch 3/5 and I committed the
binary file in /pc-bios/ (note: not in /pc-bios/optionrom/ where it is
compiled, maybe is here the confusion, but I following what was done for
the other option roms)

Of course, I forgot to add the pc-bios/optionrom/pvh.* entries in
.gitignore :)

Thanks,
Stefano