[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [Qemu-devel] [RFC PATCH 1/3] tests/vm: call make check directly for
|
From: |
Philippe Mathieu-Daudé |
|
Subject: |
Re: [Qemu-devel] [RFC PATCH 1/3] tests/vm: call make check directly for netbsd/freebsd |
|
Date: |
Mon, 21 Jan 2019 23:53:42 +0100 |
|
User-agent: |
Mozilla/5.0 (X11; Linux x86_64; rv:60.0) Gecko/20100101 Thunderbird/60.4.0 |
On 1/21/19 6:15 PM, Alex Bennée wrote:
> The "make check" target calls check-qtest which has the appropriate
> system binaries as dependencies so we shouldn't need to do two steps
> of make invocation.
>
> Signed-off-by: Alex Bennée <address@hidden>
> ---
> tests/vm/freebsd | 1 -
> 1 file changed, 1 deletion(-)
>
> diff --git a/tests/vm/freebsd b/tests/vm/freebsd
> index 19a3729172..a85c866c30 100755
> --- a/tests/vm/freebsd
> +++ b/tests/vm/freebsd
> @@ -25,7 +25,6 @@ class FreeBSDVM(basevm.BaseVM):
> cd $(mktemp -d /var/tmp/qemu-test.XXXXXX);
> tar -xf /dev/vtbd1;
> ./configure {configure_opts};
> - gmake --output-sync -j{jobs} {verbose};
> gmake --output-sync -j{jobs} check {verbose};
> """
>
Reviewed-by: Philippe Mathieu-Daudé <address@hidden>