Re: [Qemu-devel] [RFC PATCH 1/3] tests/vm: call make check directly for netbsd/freebsd

[Philippe Mathieu-Daudé]

On Mon, Jan 21, 2019 at 11:53 PM Philippe Mathieu-Daudé
<address@hidden> wrote:
>
> On 1/21/19 6:15 PM, Alex Bennée wrote:
> > The "make check" target calls check-qtest which has the appropriate
> > system binaries as dependencies so we shouldn't need to do two steps
> > of make invocation.

Now I remember, this was necessary to do this in 2 steps before
ebb61f804d6, build threaded and test not threaded.
Maybe worth adding a comment referencing this commit?

> >
> > Signed-off-by: Alex Bennée <address@hidden>
> > ---
> >  tests/vm/freebsd | 1 -
> >  1 file changed, 1 deletion(-)
> >
> > diff --git a/tests/vm/freebsd b/tests/vm/freebsd
> > index 19a3729172..a85c866c30 100755
> > --- a/tests/vm/freebsd
> > +++ b/tests/vm/freebsd
> > @@ -25,7 +25,6 @@ class FreeBSDVM(basevm.BaseVM):
> >          cd $(mktemp -d /var/tmp/qemu-test.XXXXXX);
> >          tar -xf /dev/vtbd1;
> >          ./configure {configure_opts};
> > -        gmake --output-sync -j{jobs} {verbose};
> >          gmake --output-sync -j{jobs} check {verbose};
> >      """
> >
>
> Reviewed-by: Philippe Mathieu-Daudé <address@hidden>
>