[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [Qemu-devel] [PATCH v4 0/4] trace: make systemtap easier to use for
From: |
Stefan Hajnoczi |
Subject: |
Re: [Qemu-devel] [PATCH v4 0/4] trace: make systemtap easier to use for simple logging |
Date: |
Thu, 24 Jan 2019 14:22:56 +0000 |
User-agent: |
Mutt/1.10.1 (2018-07-13) |
On Wed, Jan 23, 2019 at 12:00:12PM +0000, Daniel P. Berrangé wrote:
> This is a followup to
>
> v1: https://lists.gnu.org/archive/html/qemu-devel/2019-01/msg04173.html
> v2: https://lists.gnu.org/archive/html/qemu-devel/2019-01/msg04759.html
> v3: https://lists.gnu.org/archive/html/qemu-devel/2019-01/msg05477.html
>
> Changed in v4:
>
> - Fix license to be GPLv2-or-later (Eric)
> - Misc typo fixes (Eric)
>
> Changed in v3:
>
> - g_strndup the QXL log_buf before printing to avoid a race
> with guest removing the nul terminator (Stefan)
> - Add filtering of PIDs with "-p PID" arg to qemu-trace-stap
> - Add a man page for qemu-trace-stap (Eric)
> - Remove examples in docs/devel/tracing.txt and just refer
> people to the above man page.
> - Use strerror(errno) instead of raw errno in vfio traces (Eric/Alex)
> - Quote probe wildcards to be shell glob safe (Eric)
> - Mention explicitly that it is launched separately from QEMU (Eric)
>
> Changed in v2:
>
> - Fix safety of QXL logging
> - Handle format specifier macros is a more reliable manner
> - Fix trace-events files missing newline
> - Remove use of %m formats
>
> Daniel P. Berrangé (4):
> display: ensure qxl log_buf is a nul terminated string
> trace: enforce that every trace-events file has a final newline
> trace: forbid use of %m in trace event format strings
> trace: add ability to do simple printf logging via systemtap
>
> MAINTAINERS | 1 +
> Makefile | 10 ++
> Makefile.target | 11 +-
> docs/devel/tracing.txt | 4 +
> hw/display/qxl.c | 14 ++-
> hw/display/trace-events | 2 +-
> hw/gpio/trace-events | 2 +-
> hw/vfio/pci.c | 2 +-
> hw/vfio/trace-events | 2 +-
> scripts/qemu-trace-stap | 175 +++++++++++++++++++++++++++
> scripts/qemu-trace-stap.texi | 140 +++++++++++++++++++++
> scripts/tracetool/__init__.py | 6 +
> scripts/tracetool/format/log_stap.py | 127 +++++++++++++++++++
> 13 files changed, 487 insertions(+), 9 deletions(-)
> create mode 100755 scripts/qemu-trace-stap
> create mode 100644 scripts/qemu-trace-stap.texi
> create mode 100644 scripts/tracetool/format/log_stap.py
>
> --
> 2.20.1
>
Thanks, applied to my tracing tree:
https://github.com/stefanha/qemu/commits/tracing
Stefan
signature.asc
Description: PGP signature