[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [Qemu-devel] [libvirt] [PATCH v3 16/17] qmp: Deprecate query-events
From: |
Markus Armbruster |
Subject: |
Re: [Qemu-devel] [libvirt] [PATCH v3 16/17] qmp: Deprecate query-events in favor of query-qmp-schema |
Date: |
Thu, 07 Feb 2019 14:46:41 +0100 |
User-agent: |
Gnus/5.13 (Gnus v5.13) Emacs/26.1 (gnu/linux) |
Peter Krempa <address@hidden> writes:
> On Wed, Feb 06, 2019 at 12:42:05 -0600, Eric Blake wrote:
>> Adding libvirt in cc
>>
>> On 2/6/19 12:17 PM, Markus Armbruster wrote:
>> > query-events doesn't reflect compile-time configuration. Instead of
>> > fixing that, deprecate the command in favor of query-qmp-schema.
>> >
>> > Signed-off-by: Markus Armbruster <address@hidden>
>> > ---
>> > monitor.c | 5 +++++
>> > qapi/misc.json | 7 +++++--
>> > qemu-deprecated.texi | 5 +++++
>> > 3 files changed, 15 insertions(+), 2 deletions(-)
>>
>> Libvirt uses query-events; we'll need to patch libvirt to start relying
>> on query-qmp-schema before this deprecation cycle can complete (although
>> I'm in favor of making the change).
>
> Patches to use 'query-qmp-schema' output rather than 'query-events' in
> libvirt:
>
> https://www.redhat.com/archives/libvir-list/2019-February/msg00298.html
>
> You can start the deprecation clock.
Awesome!
- [Qemu-devel] [PATCH v3 04/17] qapi: Prepare for system modules other than 'builtin', (continued)
- [Qemu-devel] [PATCH v3 04/17] qapi: Prepare for system modules other than 'builtin', Markus Armbruster, 2019/02/06
- [Qemu-devel] [PATCH v3 09/17] qapi: make s390 commands depend on TARGET_S390X, Markus Armbruster, 2019/02/06
- [Qemu-devel] [PATCH v3 10/17] target.json: add a note about query-cpu* not being s390x-specific, Markus Armbruster, 2019/02/06
- [Qemu-devel] [PATCH v3 03/17] qapi: Clean up modular built-in code generation a bit, Markus Armbruster, 2019/02/06
- [Qemu-devel] [PATCH v3 16/17] qmp: Deprecate query-events in favor of query-qmp-schema, Markus Armbruster, 2019/02/06
- Re: [Qemu-devel] [PATCH v3 16/17] qmp: Deprecate query-events in favor of query-qmp-schema, Marc-André Lureau, 2019/02/07
[Qemu-devel] [PATCH v3 17/17] qapi: move RTC_CHANGE to the target schema, Markus Armbruster, 2019/02/06
[Qemu-devel] [PATCH v3 08/17] qapi: make rtc-reset-reinjection and SEV depend on TARGET_I386, Markus Armbruster, 2019/02/06