[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [Qemu-devel] [PATCH v3 03/17] qapi: Clean up modular built-in code g
From: |
Markus Armbruster |
Subject: |
Re: [Qemu-devel] [PATCH v3 03/17] qapi: Clean up modular built-in code generation a bit |
Date: |
Thu, 07 Feb 2019 13:46:57 +0100 |
User-agent: |
Gnus/5.13 (Gnus v5.13) Emacs/26.1 (gnu/linux) |
Marc-André Lureau <address@hidden> writes:
> Hi
>
> On Wed, Feb 6, 2019 at 7:17 PM Markus Armbruster <address@hidden> wrote:
>>
>> We neglect to call .visit_module() for the special module we use for
>> built-ins. Harmless, but clean it up anyway. The
>> tests/qapi-schema/*.out now show the built-in module as 'module None'.
>>
>> Subclasses of QAPISchemaModularCVisitor need to ._add_module() this
>> special module to enable code generation for built-ins. When this
>> hasn't been done, QAPISchemaModularCVisitor.visit_module() does
>> nothing for the special module. That looks like built-ins could
>> accidentally be generated into the wrong module when a subclass
>> neglects to call ._add_module(). Can't happen, because built-ins are
>> all visited before any other module. But that's non-obvious. Switch
>> off code generation explicitly.
>>
>> Split QAPISchemaModularCVisitor._add_module() into ._add_user_module()
>> and ._add_system_module(), for clarity.
>
> That's in next patch.
You caught me fiddling with the patch split after having written the
commit messages. Will fix.
>> Rename QAPISchemaModularCVisitor._begin_module() to
>> ._begin_user_module().
>>
>> New QAPISchemaModularCVisitor._is_builtin_module(), for clarity.
>>
>> Signed-off-by: Markus Armbruster <address@hidden>
>
> Reviewed-by: Marc-André Lureau <address@hidden>
Thanks!
- Re: [Qemu-devel] [PATCH v3 07/17] qapi: New module target.json, (continued)
- [Qemu-devel] [PATCH v3 13/17] qapi: make query-cpu-definitions depend on specific targets, Markus Armbruster, 2019/02/06
- [Qemu-devel] [PATCH v3 04/17] qapi: Prepare for system modules other than 'builtin', Markus Armbruster, 2019/02/06
- [Qemu-devel] [PATCH v3 09/17] qapi: make s390 commands depend on TARGET_S390X, Markus Armbruster, 2019/02/06
- [Qemu-devel] [PATCH v3 10/17] target.json: add a note about query-cpu* not being s390x-specific, Markus Armbruster, 2019/02/06
- [Qemu-devel] [PATCH v3 03/17] qapi: Clean up modular built-in code generation a bit, Markus Armbruster, 2019/02/06
- [Qemu-devel] [PATCH v3 16/17] qmp: Deprecate query-events in favor of query-qmp-schema, Markus Armbruster, 2019/02/06
- Re: [Qemu-devel] [PATCH v3 16/17] qmp: Deprecate query-events in favor of query-qmp-schema, Marc-André Lureau, 2019/02/07
[Qemu-devel] [PATCH v3 17/17] qapi: move RTC_CHANGE to the target schema, Markus Armbruster, 2019/02/06
[Qemu-devel] [PATCH v3 08/17] qapi: make rtc-reset-reinjection and SEV depend on TARGET_I386, Markus Armbruster, 2019/02/06