[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [Qemu-devel] [PATCH v3 07/17] qapi: New module target.json
From: |
Eric Blake |
Subject: |
Re: [Qemu-devel] [PATCH v3 07/17] qapi: New module target.json |
Date: |
Thu, 7 Feb 2019 08:58:53 -0600 |
User-agent: |
Mozilla/5.0 (X11; Linux x86_64; rv:60.0) Gecko/20100101 Thunderbird/60.4.0 |
On 2/6/19 12:17 PM, Markus Armbruster wrote:
> We can't add appropriate target-specific conditionals to misc.json,
> because that would make all of misc.json unusable in
> target-independent code. To keep misc.json target-independent, we
> need to split off target-dependent target.json.
>
> This commit doesn't actually split off anything, it merely creates the
> empty module. The next few patches will move stuff from misc.json
> there.
>
> Signed-off-by: Markus Armbruster <address@hidden>
> ---
> Makefile.objs | 20 +++++++++-----------
> Makefile.target | 10 ++++++++++
> qapi/qapi-schema.json | 1 +
> qapi/target.json | 13 +++++++++++++
> 4 files changed, 33 insertions(+), 11 deletions(-)
> create mode 100644 qapi/target.json
> +++ b/Makefile.target
> @@ -164,6 +164,16 @@ endif
>
> GENERATED_FILES += hmp-commands.h hmp-commands-info.h
>
> +# FIXME duplicates Makefile.obj's
Is this addressed later in the series, or should the commit message call
it out?
> +QAPI_TARGET_MODULES = target
> +obj-y += $(QAPI_TARGET_MODULES:%=qapi/qapi-types-%.o)
> +obj-y += qapi/qapi-types.o
> +obj-y += $(QAPI_TARGET_MODULES:%=qapi/qapi-visit-%.o)
> +obj-y += qapi/qapi-visit.o
> +obj-y += $(QAPI_TARGET_MODULES:%=qapi/qapi-events-%.o)
> +obj-y += qapi/qapi-events.o
> +obj-y += $(QAPI_TARGET_MODULES:%=qapi/qapi-commands-%.o)
> +obj-y += qapi/qapi-commands.o
> obj-y += qapi/qapi-introspect.o
>
--
Eric Blake, Principal Software Engineer
Red Hat, Inc. +1-919-301-3226
Virtualization: qemu.org | libvirt.org
signature.asc
Description: OpenPGP digital signature
- [Qemu-devel] [PATCH v3 11/17] qapi: make query-gic-capabilities depend on TARGET_ARM, (continued)
- [Qemu-devel] [PATCH v3 11/17] qapi: make query-gic-capabilities depend on TARGET_ARM, Markus Armbruster, 2019/02/06
- [Qemu-devel] [PATCH v3 05/17] qapi: Generate QAPIEvent stuff into separate files, Markus Armbruster, 2019/02/06
- [Qemu-devel] [PATCH v3 14/17] qapi: remove qmp_unregister_command(), Markus Armbruster, 2019/02/06
- [Qemu-devel] [PATCH v3 12/17] qapi: make query-cpu-model-expansion depend on s390 or x86, Markus Armbruster, 2019/02/06
- [Qemu-devel] [PATCH v3 15/17] Revert "qapi-events: add 'if' condition to implicit event enum", Markus Armbruster, 2019/02/06
- [Qemu-devel] [PATCH v3 07/17] qapi: New module target.json, Markus Armbruster, 2019/02/06
- [Qemu-devel] [PATCH v3 13/17] qapi: make query-cpu-definitions depend on specific targets, Markus Armbruster, 2019/02/06
- [Qemu-devel] [PATCH v3 04/17] qapi: Prepare for system modules other than 'builtin', Markus Armbruster, 2019/02/06
- [Qemu-devel] [PATCH v3 09/17] qapi: make s390 commands depend on TARGET_S390X, Markus Armbruster, 2019/02/06
- [Qemu-devel] [PATCH v3 10/17] target.json: add a note about query-cpu* not being s390x-specific, Markus Armbruster, 2019/02/06
- [Qemu-devel] [PATCH v3 03/17] qapi: Clean up modular built-in code generation a bit, Markus Armbruster, 2019/02/06
- [Qemu-devel] [PATCH v3 16/17] qmp: Deprecate query-events in favor of query-qmp-schema, Markus Armbruster, 2019/02/06