[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
[Qemu-devel] [PATCH v3 04/11] spice: merge options lists
From: |
Marc-André Lureau |
Subject: |
[Qemu-devel] [PATCH v3 04/11] spice: merge options lists |
Date: |
Thu, 21 Feb 2019 12:06:56 +0100 |
Passing several -spice options to qemu command line, or calling
several time qemu_opts_set() will ignore all but the first option
list. Since the spice server is a singleton, it makes sense to merge
all the options, the last value being the one taken into account.
This changes the behaviour from, for ex:
$ qemu... -spice port=5900 -spice port=5901 -> port: 5900
to:
$ qemu... -spice port=5900 -spice port=5901 -> port: 5901
(if necessary we could instead produce an error when an option is
given twice, although this makes handling default values and such more
complicated)
Signed-off-by: Marc-André Lureau <address@hidden>
Tested-by: Victor Toso <address@hidden>
---
ui/spice-core.c | 1 +
1 file changed, 1 insertion(+)
diff --git a/ui/spice-core.c b/ui/spice-core.c
index 94b31ce3ad..91d0960522 100644
--- a/ui/spice-core.c
+++ b/ui/spice-core.c
@@ -397,6 +397,7 @@ static SpiceChannelList *qmp_query_spice_channels(void)
static QemuOptsList qemu_spice_opts = {
.name = "spice",
.head = QTAILQ_HEAD_INITIALIZER(qemu_spice_opts.head),
+ .merge_lists = true,
.desc = {
{
.name = "port",
--
2.21.0.rc1
- [Qemu-devel] [PATCH v3 00/11] spice: add -display spice-app, setup and launch a Spice client, Marc-André Lureau, 2019/02/21
- [Qemu-devel] [PATCH v3 01/11] char/spice: trigger HUP event, Marc-André Lureau, 2019/02/21
- [Qemu-devel] [PATCH v3 03/11] spice: avoid spice runtime assert, Marc-André Lureau, 2019/02/21
- [Qemu-devel] [PATCH v3 02/11] char/spice: discard write() if backend is disconnected, Marc-André Lureau, 2019/02/21
- [Qemu-devel] [PATCH v3 04/11] spice: merge options lists,
Marc-André Lureau <=
- [Qemu-devel] [PATCH v3 05/11] spice: do not stop spice if VM is paused, Marc-André Lureau, 2019/02/21
- [Qemu-devel] [PATCH v3 06/11] char: move SpiceChardev and open_spice_port() to spice.h header, Marc-André Lureau, 2019/02/21
- [Qemu-devel] [PATCH v3 07/11] char: register spice ports after spice started, Marc-André Lureau, 2019/02/21
- [Qemu-devel] [PATCH v3 08/11] build-sys: add gio-2.0 check, Marc-André Lureau, 2019/02/21
- [Qemu-devel] [PATCH v3 09/11] qapi: document DisplayType enum, Marc-André Lureau, 2019/02/21
- [Qemu-devel] [PATCH v3 10/11] spice: use a default name for the server, Marc-André Lureau, 2019/02/21
- [Qemu-devel] [PATCH v3 11/11] display: add -display spice-app launching a Spice client, Marc-André Lureau, 2019/02/21