[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
[Qemu-devel] [PATCH v3 05/11] spice: do not stop spice if VM is paused
From: |
Marc-André Lureau |
Subject: |
[Qemu-devel] [PATCH v3 05/11] spice: do not stop spice if VM is paused |
Date: |
Thu, 21 Feb 2019 12:06:57 +0100 |
spice_server_vm_start/stop() was added to help migration state (commit
f5bb039c6d97ef3e664094eab3c9a4dc1824ed73).
However, a paused VM could keep running the spice server. This will
allow a Spice client to keep sending commands to a spice chardev. This
allows to stop/cont a VM from a Spice monitor port. Character
devices (vdagent/usb/smartcard/..) should not read from Spice when the
VM is paused.
Signed-off-by: Marc-André Lureau <address@hidden>
Tested-by: Victor Toso <address@hidden>
---
ui/spice-core.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/ui/spice-core.c b/ui/spice-core.c
index 91d0960522..92eebe5f0e 100644
--- a/ui/spice-core.c
+++ b/ui/spice-core.c
@@ -627,7 +627,7 @@ static void vm_change_state_handler(void *opaque, int
running,
{
if (running) {
qemu_spice_display_start();
- } else {
+ } else if (state != RUN_STATE_PAUSED) {
qemu_spice_display_stop();
}
}
--
2.21.0.rc1
- [Qemu-devel] [PATCH v3 00/11] spice: add -display spice-app, setup and launch a Spice client, Marc-André Lureau, 2019/02/21
- [Qemu-devel] [PATCH v3 01/11] char/spice: trigger HUP event, Marc-André Lureau, 2019/02/21
- [Qemu-devel] [PATCH v3 03/11] spice: avoid spice runtime assert, Marc-André Lureau, 2019/02/21
- [Qemu-devel] [PATCH v3 02/11] char/spice: discard write() if backend is disconnected, Marc-André Lureau, 2019/02/21
- [Qemu-devel] [PATCH v3 04/11] spice: merge options lists, Marc-André Lureau, 2019/02/21
- [Qemu-devel] [PATCH v3 05/11] spice: do not stop spice if VM is paused,
Marc-André Lureau <=
- [Qemu-devel] [PATCH v3 06/11] char: move SpiceChardev and open_spice_port() to spice.h header, Marc-André Lureau, 2019/02/21
- [Qemu-devel] [PATCH v3 07/11] char: register spice ports after spice started, Marc-André Lureau, 2019/02/21
- [Qemu-devel] [PATCH v3 08/11] build-sys: add gio-2.0 check, Marc-André Lureau, 2019/02/21
- [Qemu-devel] [PATCH v3 09/11] qapi: document DisplayType enum, Marc-André Lureau, 2019/02/21
- [Qemu-devel] [PATCH v3 10/11] spice: use a default name for the server, Marc-André Lureau, 2019/02/21
- [Qemu-devel] [PATCH v3 11/11] display: add -display spice-app launching a Spice client, Marc-André Lureau, 2019/02/21