[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [Qemu-ppc] [Qemu-devel] [PATCH 1/5] spapr_drc: convert to trace fram
From: |
Eric Blake |
Subject: |
Re: [Qemu-ppc] [Qemu-devel] [PATCH 1/5] spapr_drc: convert to trace framework instead of DPRINTF |
Date: |
Wed, 14 Sep 2016 14:04:10 -0500 |
User-agent: |
Mozilla/5.0 (X11; Linux x86_64; rv:45.0) Gecko/20100101 Thunderbird/45.2.0 |
On 09/14/2016 01:48 PM, Laurent Vivier wrote:
> Signed-off-by: Laurent Vivier <address@hidden>
> ---
> hw/ppc/spapr_drc.c | 54
> ++++++++++++++++++++---------------------------------
> hw/ppc/trace-events | 22 ++++++++++++++++++++++
> 2 files changed, 42 insertions(+), 34 deletions(-)
>
> diff --git a/hw/ppc/spapr_drc.c b/hw/ppc/spapr_drc.c
> index 4b1a943..6e54fd4 100644
> --- a/hw/ppc/spapr_drc.c
> +++ b/hw/ppc/spapr_drc.c
> @@ -20,20 +20,7 @@
> #include "qapi/visitor.h"
> #include "qemu/error-report.h"
> #include "hw/ppc/spapr.h" /* for RTAS return codes */
> -
> -/* #define DEBUG_SPAPR_DRC */
> -
> -#ifdef DEBUG_SPAPR_DRC
> -#define DPRINTF(fmt, ...) \
> - do { fprintf(stderr, fmt, ## __VA_ARGS__); } while (0)
> -#define DPRINTFN(fmt, ...) \
> - do { DPRINTF(fmt, ## __VA_ARGS__); fprintf(stderr, "\n"); } while (0)
> -#else
> -#define DPRINTF(fmt, ...) \
> - do { } while (0)
Yay - you're also getting rid of bit-rotting format strings!
> +++ b/hw/ppc/trace-events
> @@ -35,6 +35,28 @@ spapr_iommu_ddw_create(uint64_t buid, uint32_t cfgaddr,
> uint64_t pg_size, uint64
> spapr_iommu_ddw_remove(uint32_t liobn) "liobn=%"PRIx32
> spapr_iommu_ddw_reset(uint64_t buid, uint32_t cfgaddr) "buid=%"PRIx64"
> addr=%"PRIx32
>
> +# hw/ppc/spapr_drc.c
> +
> +spapr_drc_set_isolation_state(uint32_t index, int state) "drc: 0x%"PRIx32",
> state: %"PRIx32
Most trace files don't have a line between the comment and first
relevant function...
> # hw/ppc/ppc.c
> ppc_tb_adjust(uint64_t offs1, uint64_t offs2, int64_t diff, int64_t seconds)
> "adjusted from 0x%"PRIx64" to 0x%"PRIx64", diff %"PRId64" (%"PRId64"s)"
>
like this.
With that fixed,
Reviewed-by: Eric Blake <address@hidden>
--
Eric Blake eblake redhat com +1-919-301-3266
Libvirt virtualization library http://libvirt.org
signature.asc
Description: OpenPGP digital signature
- [Qemu-ppc] [PATCH 0/5] spapr: convert SPAPR devices to trace framework, Laurent Vivier, 2016/09/14
- [Qemu-ppc] [PATCH 1/5] spapr_drc: convert to trace framework instead of DPRINTF, Laurent Vivier, 2016/09/14
- Re: [Qemu-ppc] [Qemu-devel] [PATCH 1/5] spapr_drc: convert to trace framework instead of DPRINTF,
Eric Blake <=
- [Qemu-ppc] [PATCH 2/5] spapr_rtas: convert to trace framework instead of DPRINTF, Laurent Vivier, 2016/09/14
- [Qemu-ppc] [PATCH 3/5] spapr_vio: convert to trace framework instead of DPRINTF, Laurent Vivier, 2016/09/14
- [Qemu-ppc] [PATCH 4/5] spapr_llan: convert to trace framework instead of DPRINTF, Laurent Vivier, 2016/09/14
- [Qemu-ppc] [PATCH 5/5] spapr_vscsi: convert to trace framework instead of DPRINTF, Laurent Vivier, 2016/09/14