[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [Qemu-ppc] [Qemu-devel] [PATCH 2/5] spapr_rtas: convert to trace fra
From: |
Eric Blake |
Subject: |
Re: [Qemu-ppc] [Qemu-devel] [PATCH 2/5] spapr_rtas: convert to trace framework instead of DPRINTF |
Date: |
Wed, 14 Sep 2016 14:11:41 -0500 |
User-agent: |
Mozilla/5.0 (X11; Linux x86_64; rv:45.0) Gecko/20100101 Thunderbird/45.2.0 |
On 09/14/2016 01:48 PM, Laurent Vivier wrote:
> Signed-off-by: Laurent Vivier <address@hidden>
> ---
> hw/ppc/spapr_rtas.c | 30 ++++++++----------------------
> hw/ppc/trace-events | 9 +++++++++
> 2 files changed, 17 insertions(+), 22 deletions(-)
>
> +++ b/hw/ppc/trace-events
> @@ -57,6 +57,15 @@ spapr_drc_realize_child(uint32_t index, char *childname)
> "drc: 0x%"PRIx32", chil
> spapr_drc_realize_complete(uint32_t index) "drc: 0x%"PRIx32
> spapr_drc_unrealize(uint32_t index) "drc: 0x%"PRIx32
>
> +# hw/ppc/spapr_rtas.c
> +
> +spapr_rtas_set_indicator_invalid(uint32_t index) "sensor index: 0x%"PRIx32
Same comment about extra newline as on 1/5 (and probably for the whole
series); otherwise:
Reviewed-by: Eric Blake <address@hidden>
--
Eric Blake eblake redhat com +1-919-301-3266
Libvirt virtualization library http://libvirt.org
signature.asc
Description: OpenPGP digital signature
- [Qemu-ppc] [PATCH 0/5] spapr: convert SPAPR devices to trace framework, Laurent Vivier, 2016/09/14
- [Qemu-ppc] [PATCH 1/5] spapr_drc: convert to trace framework instead of DPRINTF, Laurent Vivier, 2016/09/14
- [Qemu-ppc] [PATCH 2/5] spapr_rtas: convert to trace framework instead of DPRINTF, Laurent Vivier, 2016/09/14
- Re: [Qemu-ppc] [Qemu-devel] [PATCH 2/5] spapr_rtas: convert to trace framework instead of DPRINTF,
Eric Blake <=
- [Qemu-ppc] [PATCH 3/5] spapr_vio: convert to trace framework instead of DPRINTF, Laurent Vivier, 2016/09/14
- [Qemu-ppc] [PATCH 4/5] spapr_llan: convert to trace framework instead of DPRINTF, Laurent Vivier, 2016/09/14
- [Qemu-ppc] [PATCH 5/5] spapr_vscsi: convert to trace framework instead of DPRINTF, Laurent Vivier, 2016/09/14