[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [Qemu-ppc] [PATCH-for-4.1? 5/7] target/ppc: Rewrite a fall through c
From: |
David Gibson |
Subject: |
Re: [Qemu-ppc] [PATCH-for-4.1? 5/7] target/ppc: Rewrite a fall through comment |
Date: |
Sat, 20 Jul 2019 00:20:13 +1000 |
User-agent: |
Mutt/1.12.0 (2019-05-25) |
On Fri, Jul 19, 2019 at 03:14:23PM +0200, Philippe Mathieu-Daudé wrote:
> GCC9 is confused by this comment when building with CFLAG
> -Wimplicit-fallthrough=2:
>
> target/ppc/mmu_helper.c: In function ‘dump_mmu’:
> target/ppc/mmu_helper.c:1349:12: error: this statement may fall through
> [-Werror=implicit-fallthrough=]
> 1349 | if (ppc64_v3_radix(env_archcpu(env))) {
> | ^
> target/ppc/mmu_helper.c:1356:5: note: here
> 1356 | default:
> | ^~~~~~~
> cc1: all warnings being treated as errors
>
> Rewrite the comment using 'fall through' which is recognized by
> GCC and static analyzers.
>
> Reported-by: Stefan Weil <address@hidden>
> Signed-off-by: Philippe Mathieu-Daudé <address@hidden>
Acked-by: David Gibson <address@hidden>
> ---
> target/ppc/mmu_helper.c | 6 +++---
> 1 file changed, 3 insertions(+), 3 deletions(-)
>
> diff --git a/target/ppc/mmu_helper.c b/target/ppc/mmu_helper.c
> index 261a8fe707..862824b073 100644
> --- a/target/ppc/mmu_helper.c
> +++ b/target/ppc/mmu_helper.c
> @@ -98,7 +98,7 @@ static int pp_check(int key, int pp, int nx)
> case 0x1:
> case 0x2:
> access |= PAGE_WRITE;
> - /* No break here */
> + /* fall through */
> case 0x3:
> access |= PAGE_READ;
> break;
> @@ -706,7 +706,7 @@ static int mmu40x_get_physical_address(CPUPPCState *env,
> mmu_ctx_t *ctx,
> if (pr != 0) {
> goto check_perms;
> }
> - /* No break here */
> + /* fall through */
> case 0x3:
> /* All accesses granted */
> ctx->prot = PAGE_READ | PAGE_WRITE | PAGE_EXEC;
> @@ -720,7 +720,7 @@ static int mmu40x_get_physical_address(CPUPPCState *env,
> mmu_ctx_t *ctx,
> ret = -2;
> break;
> }
> - /* No break here */
> + /* fall through */
> case 0x1:
> check_perms:
> /* Check from TLB entry */
--
David Gibson | I'll have my music baroque, and my code
david AT gibson.dropbear.id.au | minimalist, thank you. NOT _the_ _other_
| _way_ _around_!
http://www.ozlabs.org/~dgibson
signature.asc
Description: PGP signature
- [Qemu-ppc] [PATCH-for-4.1? 2/7] hw/dma/omap_dma: Move switch 'fall through' comment to correct place, (continued)
- [Qemu-ppc] [PATCH-for-4.1? 4/7] hw/ipmi: Rewrite a fall through comment, Philippe Mathieu-Daudé, 2019/07/19
- [Qemu-ppc] [PATCH-for-4.1? 5/7] target/ppc: Rewrite a fall through comment, Philippe Mathieu-Daudé, 2019/07/19
- Re: [Qemu-ppc] [PATCH-for-4.1? 5/7] target/ppc: Rewrite a fall through comment,
David Gibson <=
- [Qemu-ppc] [PATCH-for-4.1? 6/7] vl: Rewrite a fall through comment, Philippe Mathieu-Daudé, 2019/07/19
- [Qemu-ppc] [PATCH-for-4.1? 7/7] spapr_events: Rewrite a fall through comment, Philippe Mathieu-Daudé, 2019/07/19