[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [Qemu-ppc] [PATCH-for-4.1? 4/7] hw/ipmi: Rewrite a fall through comm
From: |
Corey Minyard |
Subject: |
Re: [Qemu-ppc] [PATCH-for-4.1? 4/7] hw/ipmi: Rewrite a fall through comment |
Date: |
Sat, 20 Jul 2019 21:10:16 -0500 |
User-agent: |
Mutt/1.9.4 (2018-02-28) |
On Fri, Jul 19, 2019 at 03:14:22PM +0200, Philippe Mathieu-Daudé wrote:
> GCC9 is confused by this comment when building with CFLAG
> -Wimplicit-fallthrough=2:
>
> hw/ipmi/ipmi_bmc_extern.c: In function ‘addchar’:
> hw/ipmi/ipmi_bmc_extern.c:178:12: error: this statement may fall through
> [-Werror=implicit-fallthrough=]
> 178 | ch |= 0x10;
> | ~~~^~~~~~~
> hw/ipmi/ipmi_bmc_extern.c:181:5: note: here
> 181 | default:
> | ^~~~~~~
> cc1: all warnings being treated as errors
> make: *** [rules.mak:69: hw/ipmi/ipmi_bmc_extern.o] Error 1
>
> Rewrite the comment using 'fall through' which is recognized by
> GCC and static analyzers.
>
> Reported-by: Stefan Weil <address@hidden>
> Signed-off-by: Philippe Mathieu-Daudé <address@hidden>
> ---
> hw/ipmi/ipmi_bmc_extern.c | 3 +--
> 1 file changed, 1 insertion(+), 2 deletions(-)
>
> diff --git a/hw/ipmi/ipmi_bmc_extern.c b/hw/ipmi/ipmi_bmc_extern.c
> index c0a8dac346..d4cbd210c4 100644
> --- a/hw/ipmi/ipmi_bmc_extern.c
> +++ b/hw/ipmi/ipmi_bmc_extern.c
> @@ -176,8 +176,7 @@ static void addchar(IPMIBmcExtern *ibe, unsigned char ch)
> ibe->outbuf[ibe->outlen] = VM_ESCAPE_CHAR;
> ibe->outlen++;
> ch |= 0x10;
> - /* No break */
> -
> + /* fall through */
> default:
> ibe->outbuf[ibe->outlen] = ch;
> ibe->outlen++;
> --
> 2.20.1
>
Well, whatever, this is fine.
Acked-by: Corey Minyard <address@hidden>
- [Qemu-ppc] [PATCH-for-4.1? 1/7] json: Move switch 'fall through' comment to correct place, (continued)
- [Qemu-ppc] [PATCH-for-4.1? 4/7] hw/ipmi: Rewrite a fall through comment, Philippe Mathieu-Daudé, 2019/07/19
- Re: [Qemu-ppc] [PATCH-for-4.1? 4/7] hw/ipmi: Rewrite a fall through comment,
Corey Minyard <=
- [Qemu-ppc] [PATCH-for-4.1? 5/7] target/ppc: Rewrite a fall through comment, Philippe Mathieu-Daudé, 2019/07/19
- [Qemu-ppc] [PATCH-for-4.1? 6/7] vl: Rewrite a fall through comment, Philippe Mathieu-Daudé, 2019/07/19
- [Qemu-ppc] [PATCH-for-4.1? 7/7] spapr_events: Rewrite a fall through comment, Philippe Mathieu-Daudé, 2019/07/19