[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [PATCH v2 11/14] target/ppc: 405: Data Storage exception cleanup
From: |
David Gibson |
Subject: |
Re: [PATCH v2 11/14] target/ppc: 405: Data Storage exception cleanup |
Date: |
Wed, 19 Jan 2022 17:13:31 +1100 |
On Tue, Jan 18, 2022 at 03:44:45PM -0300, Fabiano Rosas wrote:
> The 405 has no DSISR or DAR, so convert the trace entry to
> trace_ppc_excp_print.
I think it would be preferable to show ESR and DEAR here, which are
very loosely equivalent to DSISR and DAR on 40x. Might want to create
a new trace point explicitly for this so the terminology is clear as well.
>
> Signed-off-by: Fabiano Rosas <farosas@linux.ibm.com>
> ---
> target/ppc/excp_helper.c | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/target/ppc/excp_helper.c b/target/ppc/excp_helper.c
> index 84ec7e094a..e4e513322c 100644
> --- a/target/ppc/excp_helper.c
> +++ b/target/ppc/excp_helper.c
> @@ -465,7 +465,7 @@ static void powerpc_excp_40x(PowerPCCPU *cpu, int excp)
> srr1 = SPR_40x_SRR3;
> break;
> case POWERPC_EXCP_DSI: /* Data storage exception
> */
> - trace_ppc_excp_dsi(env->spr[SPR_DSISR], env->spr[SPR_DAR]);
> + trace_ppc_excp_print("DSI");
> break;
> case POWERPC_EXCP_ISI: /* Instruction storage exception
> */
> trace_ppc_excp_isi(msr, env->nip);
--
David Gibson | I'll have my music baroque, and my code
david AT gibson.dropbear.id.au | minimalist, thank you. NOT _the_ _other_
| _way_ _around_!
http://www.ozlabs.org/~dgibson
signature.asc
Description: PGP signature
- [PATCH v2 14/14] target/ppc: 405: Watchdog timer exception cleanup, (continued)
- [PATCH v2 14/14] target/ppc: 405: Watchdog timer exception cleanup, Fabiano Rosas, 2022/01/18
- [PATCH v2 10/14] target/ppc: 405: Debug exception cleanup, Fabiano Rosas, 2022/01/18
- [PATCH v2 04/14] target/ppc: Simplify powerpc_excp_40x, Fabiano Rosas, 2022/01/18
- [PATCH v2 07/14] target/ppc: 405: External exception cleanup, Fabiano Rosas, 2022/01/18
- [PATCH v2 11/14] target/ppc: 405: Data Storage exception cleanup, Fabiano Rosas, 2022/01/18
- Re: [PATCH v2 11/14] target/ppc: 405: Data Storage exception cleanup,
David Gibson <=
- [PATCH v2 09/14] target/ppc: 405: Alignment exception cleanup, Fabiano Rosas, 2022/01/18
- [PATCH v2 12/14] target/ppc: 405: Instruction storage interrupt cleanup, Fabiano Rosas, 2022/01/18
- [PATCH v2 13/14] target/ppc: 405: Program exception cleanup, Fabiano Rosas, 2022/01/18