Re: [rdiff-backup-users] Can't do file restore - "Could not gettime of current mirror"

[Ben Escoto]

On Wed, 29 Oct 2003 19:16:55 -0500 (EST) "Daniel M. Drucker" <address@hidden> 
wrote:
> > How many rdiff-backup-data/current_mirror.* files are there?  If there
> > are 0 or 2, then the first backup didn't work.  (If it said it worked,
> > then there is a bug with backing up, not with restoring.)
> 
> There is one:
> 
> -rw-------  1 root  wheel   0 Oct 29 18:41
> current_mirror.2003-10-29;08418;05841;05847-04;05800.data

Ahh, I see the quoting code has been turned on; the problem must be that
when restoring it is looking for an unquoted current_mirror marker.  Is
there an rdiff-backup-data/chars_to_quote file?  What does it say?

BTW, thanks for testing the development version.  The automatic quoting
stuff is a good example of something that's hard for me to test on my
own system, because all my filesystems are case sensitive.

> > Must be a bug in the security code then.  I thought I fixed them all for
> > 0.13.3 but apparently not.  Probably you just need to add
> > FilenameMapping.set_init_quote_vals_local to the top of Security.py, but
> 
> What do you mean by "to the top of"? Where exactly does that need to go?

Well, I was thinking that something like this may fix it:

--- Security.py 2003-10-14 10:34:17.000000000 -0700
+++ Security.py.new     2003-10-29 18:04:28.000000000 -0800
@@ -112,6 +112,7 @@
        allowed_requests = ["VirtualFile.readfromid", "VirtualFile.closebyid",
                                                "Globals.get", 
"Globals.is_not_None",
                                                "Globals.get_dict_val",
+                                               
"FilenameMapping.set_init_quote_vals_local",
                                                "log.Log.open_logfile_allconn",
                                                "log.Log.close_logfile_allconn",
                                                "Log.log_to_file",
@@ -166,7 +167,6 @@
                         "log.Log.setverbosity",
                         "log.Log.setterm_verbosity",
                         "Time.setprevtime_local",
-                        "FilenameMapping.set_init_quote_vals_local",
                         "Globals.postset_regexp_local",
                         "Globals.set_select",
                         "backup.SourceStruct.set_session_info",

but the time consuming part will be to write a test case that finds this
bug.


-- 
Ben Escoto

pgpq8tNhDJwUL.pgp
Description: PGP signature