[rdiff-backup-users] Re: --check-destination-dir fails after a crash (redux)

[Sebastien Maret]

Sebastien Maret <address@hidden> writes:

> Gordon Rowell <address@hidden> writes:
>
>> I experienced the error shown here:
>>
>>    
>> http://lists.nongnu.org/archive/html/rdiff-backup-users/2006-03/msg00038.html
>>
>> and applied the patch show here:
>>
>>    
>> http://lists.nongnu.org/archive/html/rdiff-backup-users/2006-03/msg00039.html
>>
>> which worked for me, but I haven't seen any further follow-up and the
>> patch doesn't seem to have been applied in CVS.
>>
>> Is it the correct fix?
>
> Not sure it is.
>
> I had the same problem today, and applied the patch. Now I get:
>
>
> % rdiff-backup --check-destination-dir --force /Lorien2/spitzer/Backup
> Exception '[Errno 2] No such file or directory: 
> '/Lorien2/spitzer/Backup/rdiff-backup-data/mirror_metadata.2006-10-04T01:02:23-04:00.snapshot.gz''
>  raised of class 'exceptions.OSError':
>   File "/sw/lib/python2.4/site-packages/rdiff_backup/Main.py", line 295, in 
> error_check_Main
>     try: Main(arglist)
>   File "/sw/lib/python2.4/site-packages/rdiff_backup/Main.py", line 315, in 
> Main
>     take_action(rps)
>   File "/sw/lib/python2.4/site-packages/rdiff_backup/Main.py", line 273, in 
> take_action
>     elif action == "check-destination-dir": CheckDest(rps[0])
>   File "/sw/lib/python2.4/site-packages/rdiff_backup/Main.py", line 781, in 
> CheckDest
>     dest_rp.conn.regress.Regress(dest_rp)
>   File "/sw/lib/python2.4/site-packages/rdiff_backup/regress.py", line 69, in 
> Regress
>     regress_rbdir(manager)
>   File "/sw/lib/python2.4/site-packages/rdiff_backup/regress.py", line 124, 
> in regress_rbdir
>     if has_meta_diff and not has_meta_snap: recreate_meta(meta_manager)
>   File "/sw/lib/python2.4/site-packages/rdiff_backup/regress.py", line 153, 
> in recreate_meta
>     rpath.rename(temprp, finalrp)
>   File "/sw/lib/python2.4/site-packages/rdiff_backup/rpath.py", line 230, in 
> rename
>     if not rp_source.lstat(): rp_dest.delete()
>   File "/sw/lib/python2.4/site-packages/rdiff_backup/rpath.py", line 946, in 
> delete
>     else: self.conn.os.unlink(self.path)
>
> Traceback (most recent call last):
>   File "/sw/bin/rdiff-backup", line 23, in ?
>     rdiff_backup.Main.error_check_Main(sys.argv[1:])
>   File "/sw/lib/python2.4/site-packages/rdiff_backup/Main.py", line 295, in 
> error_check_Main
>     try: Main(arglist)
>   File "/sw/lib/python2.4/site-packages/rdiff_backup/Main.py", line 315, in 
> Main
>     take_action(rps)
>   File "/sw/lib/python2.4/site-packages/rdiff_backup/Main.py", line 273, in 
> take_action
>     elif action == "check-destination-dir": CheckDest(rps[0])
>   File "/sw/lib/python2.4/site-packages/rdiff_backup/Main.py", line 781, in 
> CheckDest
>     dest_rp.conn.regress.Regress(dest_rp)
>   File "/sw/lib/python2.4/site-packages/rdiff_backup/regress.py", line 69, in 
> Regress
>     regress_rbdir(manager)
>   File "/sw/lib/python2.4/site-packages/rdiff_backup/regress.py", line 124, 
> in regress_rbdir
>     if has_meta_diff and not has_meta_snap: recreate_meta(meta_manager)
>   File "/sw/lib/python2.4/site-packages/rdiff_backup/regress.py", line 153, 
> in recreate_meta
>     rpath.rename(temprp, finalrp)
>   File "/sw/lib/python2.4/site-packages/rdiff_backup/rpath.py", line 230, in 
> rename
>     if not rp_source.lstat(): rp_dest.delete()
>   File "/sw/lib/python2.4/site-packages/rdiff_backup/rpath.py", line 946, in 
> delete
>     else: self.conn.os.unlink(self.path)
> OSError: [Errno 2] No such file or directory: 
> '/Lorien2/spitzer/Backup/rdiff-backup-data/mirror_metadata.2006-10-04T01:02:23-04:00.snapshot.gz'
>
> Sébastien

I have tried the following:

% touch 
/Lorien2/spitzer/Backup/rdiff-backup-data/mirror_metadata.2006-10-04T01:02:23-04:00.snapshot.gz
% rdiff-backup --check-destination-dir --force /Lorien2/spitzer/BackupException 
'[Errno 2] No such file or directory: 
'/Lorien2/spitzer/Backup/rdiff-backup-data/increments.2006-10-04T01:02:23-04:00.dir''
 raised of class 'exceptions.OSError':
  File "/sw/lib/python2.4/site-packages/rdiff_backup/Main.py", line 295, in 
error_check_Main
    try: Main(arglist)
  File "/sw/lib/python2.4/site-packages/rdiff_backup/Main.py", line 315, in Main
    take_action(rps)
  File "/sw/lib/python2.4/site-packages/rdiff_backup/Main.py", line 273, in 
take_action
    elif action == "check-destination-dir": CheckDest(rps[0])
  File "/sw/lib/python2.4/site-packages/rdiff_backup/Main.py", line 781, in 
CheckDest
    dest_rp.conn.regress.Regress(dest_rp)
  File "/sw/lib/python2.4/site-packages/rdiff_backup/regress.py", line 72, in 
Regress
    ITR.Finish()
  File "/sw/lib/python2.4/site-packages/rdiff_backup/rorpiter.py", line 247, in 
Finish
    to_be_finished.end_process()
  File "/sw/lib/python2.4/site-packages/rdiff_backup/regress.py", line 331, in 
end_process
    rf.regress_inc.delete()
  File "/sw/lib/python2.4/site-packages/rdiff_backup/rpath.py", line 946, in 
delete
    else: self.conn.os.unlink(self.path)

Traceback (most recent call last):
  File "/sw/bin/rdiff-backup", line 23, in ?
    rdiff_backup.Main.error_check_Main(sys.argv[1:])
  File "/sw/lib/python2.4/site-packages/rdiff_backup/Main.py", line 295, in 
error_check_Main
    try: Main(arglist)
  File "/sw/lib/python2.4/site-packages/rdiff_backup/Main.py", line 315, in Main
    take_action(rps)
  File "/sw/lib/python2.4/site-packages/rdiff_backup/Main.py", line 273, in 
take_action
    elif action == "check-destination-dir": CheckDest(rps[0])
  File "/sw/lib/python2.4/site-packages/rdiff_backup/Main.py", line 781, in 
CheckDest
    dest_rp.conn.regress.Regress(dest_rp)
  File "/sw/lib/python2.4/site-packages/rdiff_backup/regress.py", line 72, in 
Regress
    ITR.Finish()
  File "/sw/lib/python2.4/site-packages/rdiff_backup/rorpiter.py", line 247, in 
Finish
    to_be_finished.end_process()
  File "/sw/lib/python2.4/site-packages/rdiff_backup/regress.py", line 331, in 
end_process
    rf.regress_inc.delete()
  File "/sw/lib/python2.4/site-packages/rdiff_backup/rpath.py", line 946, in 
delete
    else: self.conn.os.unlink(self.path)
OSError: [Errno 2] No such file or directory: 
'/Lorien2/spitzer/Backup/rdiff-backup-data/increments.2006-10-04T01:02:23-04:00.dir'
[lorien:~] smaret% cd /Lorien2/spitzer/Backup/                  
-bash: cd: /Lorien2/spitzer/Backup/: No such file or directory

Turns out to be a *very* bad idea. The whole backup directory is now
gone. Sounds like a *critical bug* to me. How can rdiff-backup delete
the whole backup directory like that???