Re: [Sks-devel] 1.0.8 release candidate

[Jason Harris]

On Mon, Oct 04, 2004 at 09:33:05AM -0400, Yaron Minsky wrote:

> Indeed, they are not fixed, largely because I did not know about them
> until now.  I think 1.0.8 will probably be released without these
> changes, since I've just spent a bunch of time hacking, and can't make
> more right now unless it's quite urgent.
 
> That said, if someone submits patches for these issues in the next few
> days, I would be happy to include them in the final 1.0.8 release. 
> The changes should be pretty simple to do.

See below.

> On Mon, 04 Oct 2004 15:26:34 +0200, Reimer Karlsen, DFN-CERT
> <address@hidden> wrote:

> > In this case PKS returns a 200 and some humanreadable information about too
> > many returned key matches:
> > 
> > ~ Public Key Server -- Error
> > 
> > ~ Number of keys in reply (544) exceeded maximum allowed (500) Try a more
> > ~ specific query.

Modify keydb.ml like this:

-       then raise (Invalid_argument "Insufficiently specific words");
+       then raise (Invalid_argument (sprintf "Number of keys in reply (%d) 
exceeded maximum allowed (%d).  Try a more specific query." (MList.min lengths) 
max_internal_matches));

> > 2. and 3. When requesting specificly a key id starting the search string
> > with 0x SKS thoughs an ugly exception when the actual keyid is not a valid
> > hex string.
> > 
> > If PKS is asked
> > 
> > http://blackhole.pca.dfn.de:11371/pks/lookup?op=index&search=0xkarlsen
> > 
> > it returns a 200 HTTP error code and the following message:
> > 
> > ~ Public Key Server -- Error
> > 
> > ~ Key ID string should be 8, 16, or 40 characters long
> > 
> > If PKS is asked
> > 
> > http://blackhole.pca.dfn.de:11371/pks/lookup?op=index&search=0xkarlsena
> > 
> > it returns a 200 HTTP error code and the following message:
> > 
> > ~ Public Key Server -- Error
> > 
> > ~ Key ID must contain only hexadecimal digits

Start by changing both instances of 500 to 200 in wserver.ml.

-- 
Jason Harris           |  NIC:  JH329, PGP:  This _is_ PGP-signed, isn't it?
address@hidden _|_ web:  http://keyserver.kjsl.com/~jharris/
          Got photons?   (TM), (C) 2004

pgpR192nRgeEy.pgp
Description: PGP signature