sks-devel
[Top][All Lists]
Advanced

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

Re: [Sks-devel] Re: SKS v. unknown HTTP headers (was: Re: IPv6 failover?


From: Yaron Minsky
Subject: Re: [Sks-devel] Re: SKS v. unknown HTTP headers (was: Re: IPv6 failover?)
Date: Fri, 5 Aug 2005 07:56:50 -0400

As you can tell from the SKS keyserver, I'm no expert on HTTP.  Under what circumstances is the character in question an =, and in what case is it a %?  Are there any other possibilities?

y

On 8/5/05, Jason Harris <address@hidden> wrote:
On Thu, Aug 04, 2005 at 07:54:09AM -0400, David Shaw wrote:
> On Thu, Aug 04, 2005 at 12:24:27AM -0400, Jason Harris wrote:

> > Thus, in reality, the "Expect: 100-continue" header appears to be confusing
> > SKS (during POSTs).

> Hmm.  No really good way to fix that in GPG or curl since they can't
> detect that a server is 1.0 without doing a GET first.  Curl, if I

Disregard that.

It isn't the Expect: header, it was the [s]scanf.  This patch fixes it:

diff -u -r1.5 dbserver.ml
--- dbserver.ml
+++ dbserver.ml
@@ -415,8 +415,9 @@
          let request = Wserver.strip request in
          match request with
              "/pks/add" ->
-               let keytext = Scanf.sscanf body "keytext=%s" (fun s -> s) in
+               let keytext = Scanf.sscanf body "keytext%s" (fun s -> s) in
                let keytext = Wserver.decode keytext in
+               let keytext = Str.string_after keytext 1 in
                let keys = Armor.decode_pubkey keytext in
                plerror 3 "Handling /pks/add for %d keys"
                  (List.length keys);

--
Jason Harris           |  NIC:  JH329, PGP:  This _is_ PGP-signed, isn't it?
address@hidden _|_ web:  http://keyserver.kjsl.com/~jharris/
          Got photons?   (TM), (C) 2004


_______________________________________________
Sks-devel mailing list
address@hidden
http://lists.nongnu.org/mailman/listinfo/sks-devel





reply via email to

[Prev in Thread] Current Thread [Next in Thread]