spamass-milter causes spamassassin to not clean up after itself?

[Tony Shadwick]

I've been using spamass-milter for many, MANY years now, so admittedly 
this is the first time I've noticed this.  My past environments have been 
*much* smaller, so as a result, it's not mattered.

My current installation is insanely large.  We process some absurd number 
of messages per minute on a single box.  spamass-milter has held up like a 
champ, however my filesystem keeps filling up from /tmp/.spamassassin* 
directories that never seem to go away.

In actuality, what's happening is these files stay put until a certain 
time has expired or the process ends, *then* the files are supposed to go 
away.  In reality, they never go away. :P  This is an effect of staying 
portable with win32.  The problem resolution is actually very simple, and 
spamass-milter isn't hte only thing to get bitten by it.  MimeDefang got 
bitten by the same thing a while back:

https://issues.apache.org/SpamAssassin/show_bug.cgi?id=5444

The short answer is that "all users of the Mail::SpamAssassin classes
should always call $mail->finish() on every mail object, otherwise it'll 
leak memory, leave temporary files around, etc."

It seems common practice that milters and the like have in the past called 
$status->finish() but not $mail->finish().  I in fact made that same 
error in my own home-grown milter here.  It's a copy-and-paste-ism.

We need to make sure that this happens in spamass-milter as well. :)

kthx!