a2ps-patches
[Top][All Lists]
Advanced

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

Re: [patch] Fix to let a2ps handle FlateDecode from its delegates


From: Jason McCarty
Subject: Re: [patch] Fix to let a2ps handle FlateDecode from its delegates
Date: Tue, 24 Sep 2002 20:15:28 -0400
User-agent: Mutt/1.4i

On Tue, Sep 24, 2002 at 01:22:55PM +0200, Akim Demaille wrote:
> 
> | Hi,
> | I sent this to the bug-a2ps address last month, but it looks like this
> | might be a better list to send it to.
> 
> Hi Jason,
> 
> Thanks for the submission, it is correct, and goes into the correct
> direction.  Nevertheless, I would much prefer a patch that use
> getline, as the rest of a2ps already does.  Would you submit a revised
> patch?  With a ChangeLog entry?  Thanks in advance!

Sure, actually I guess using getline is better, since it introduces less
new code. Happily, I managed to get CVS a2ps compiled this time
(autoreconf from bootstrap was calling aclocal-1.4, even though I have
1.6 installed).

My fix works, but unfortunately, I found that it only fixes things when
"-1" is given as an option, so the output must be getting mangled
somewhere else whenever more than one page per sheet is requested. I'll
try fixing that too eventually, but for now I'm happy with correct
output with one page per sheet.

Thanks,
  Jason

Changelog entry:

2002-09-24

  * src/delegate.c: Change fgets()/fputs() loop to getline()/fwrite()
  loop, in order to handle null zeroes from delegate programs.
  From Jason McCarty <address@hidden>.

Attachment: a2ps-getline.patch
Description: Text document


reply via email to

[Prev in Thread] Current Thread [Next in Thread]