[Top][All Lists]
[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: Cleanup on AC_MSG_ERROR
From: |
Akim Demaille |
Subject: |
Re: Cleanup on AC_MSG_ERROR |
Date: |
24 Oct 2000 17:46:39 +0200 |
User-agent: |
Gnus/5.0807 (Gnus v5.8.7) XEmacs/21.1 (Channel Islands) |
>>>>> "Pavel" == Pavel Roskin <address@hidden> writes:
>> + echo "configure: exit ($exit_status)" >&AC_FD_LOG
Pavel> We probably don't want parentheses to be in config.log: echo
Pavel> "configure: exit $exit_status" >&AC_FD_LOG
OK.
Pavel> I don't want to undo my previous patch because I believe it was
Pavel> correct. It's a good style for tests to remove temporary files
Pavel> created by them.
Your previous patches are needed, it is important to clean before and
after.
Clean before, because you're never sure the previous guy did not leave
a file you will try to create and then test -f. It could lead to a
false success. Conversely, clean afterwards, because the next guy
might have forgotten to clean up.
So I really do believe your cleaning patches are needed, and I'll be
happy to see your tests included in the test suite.