Re: Optimization for install-sh

[Alexandre Oliva]

On Nov  9, 2000, "Lars J. Aas" <address@hidden> wrote:

> On Wed, Nov 08, 2000 at 04:44:47PM -0500, Pavel Roskin wrote:
> :  if [ x"$dir_arg" != x ]; then
> :     if [ -f $src -o -d $src ]
> : +   if [ x"$chowncmd" != x ]; then $doit $chowncmd $dst; else : ; fi &&
> : +   if [ x"$chgrpcmd" != x ]; then $doit $chgrpcmd $dst; else : ; fi &&
> : +   if [ x"$stripcmd" != x ]; then $doit $stripcmd $dst; else : ; fi &&
> : +   if [ x"$chmodcmd" != x ]; then $doit $chmodcmd $dst; else : ; fi
> : +   if [ x"$chowncmd" != x ]; then $doit $chowncmd $dsttmp; else :;fi &&
> : +   if [ x"$chgrpcmd" != x ]; then $doit $chgrpcmd $dsttmp; else :;fi &&
> : +   if [ x"$stripcmd" != x ]; then $doit $stripcmd $dsttmp; else :;fi &&
> : +   if [ x"$chmodcmd" != x ]; then $doit $chmodcmd $dsttmp; else :;fi &&

> Shouldn't all these be rewritten as "if test ...;" instead?

Or, even better (IMHO):

{ test "x$...cmd" = x || $doit $...cmd $arg ; }

-- 
Alexandre Oliva   Enjoy Guarana', see http://www.ic.unicamp.br/~oliva/
Red Hat GCC Developer                  address@hidden, redhat.com}
CS PhD student at IC-Unicamp        address@hidden, gnu.org}
Free Software Evangelist    *Please* write to mailing lists, not to me