[Top][All Lists]
[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: AS_MESSAGE_FD
From: |
Eric Blake |
Subject: |
Re: AS_MESSAGE_FD |
Date: |
Sun, 23 Nov 2008 07:20:20 -0700 |
User-agent: |
Mozilla/5.0 (Windows; U; Windows NT 5.1; en-US; rv:1.8.1.18) Gecko/20081105 Thunderbird/2.0.0.18 Mnenhy/0.7.5.666 |
-----BEGIN PGP SIGNED MESSAGE-----
Hash: SHA1
According to Ralf Wildenhues on 11/23/2008 12:50 AM:
>> The semantics should be identical for third-party use;
>
> assuming that no third-party code uses m4_ifdef([AS_MESSAGE_LOG_FD]).
> Right?
If they were using m4_ifdef([AS_MESSAGE_LOG_FD]), they were broken unless
they also checked its contents (in which case m4_ifset is the most compact
way to check that it is both defined and non-empty) - this patch does not
change the fact that it is valid to be defined but empty, in which case
logging is disabled.
>
> FWIW, I haven't found using this, but it is a semantic change this way.
I still don't think there is an issue by having m4sh provide a default
empty definition.
- --
Don't work too hard, make some time for fun as well!
Eric Blake address@hidden
-----BEGIN PGP SIGNATURE-----
Version: GnuPG v1.4.9 (Cygwin)
Comment: Public key at home.comcast.net/~ericblake/eblake.gpg
Comment: Using GnuPG with Mozilla - http://enigmail.mozdev.org
iEYEARECAAYFAkkpZqQACgkQ84KuGfSFAYAY5ACfXbgoqNn7+YK9qSi5Fam6FbBt
vM4AoJPA72QoPYDLhv4RaJyZKFTOMHTi
=s5rD
-----END PGP SIGNATURE-----
- Re: [PATCH] Pass CONFIG_SHELL down if provided, (continued)
- Re: [PATCH] Pass CONFIG_SHELL down if provided, Eric Blake, 2008/11/12
- Re: [PATCH] Pass CONFIG_SHELL down if provided, Paolo Bonzini, 2008/11/12
- Re: [PATCH] Pass CONFIG_SHELL down if provided, Eric Blake, 2008/11/12
- Re: [PATCH] Pass CONFIG_SHELL down if provided, Eric Blake, 2008/11/12
- AS_MESSAGE_FD [was: [PATCH] Pass CONFIG_SHELL down if provided], Eric Blake, 2008/11/12
- Re: AS_MESSAGE_FD, Eric Blake, 2008/11/21
- Re: AS_MESSAGE_FD, Eric Blake, 2008/11/22
- Re: AS_MESSAGE_FD, Ralf Wildenhues, 2008/11/22
- Re: AS_MESSAGE_FD, Eric Blake, 2008/11/22
- Re: AS_MESSAGE_FD, Ralf Wildenhues, 2008/11/23
- Re: AS_MESSAGE_FD,
Eric Blake <=
- Re: AS_MESSAGE_FD, Eric Blake, 2008/11/24
Re: [PATCH] Pass CONFIG_SHELL down if provided, Paolo Bonzini, 2008/11/12