[Top][All Lists]
[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [Automake-NG] [PATCH 12/17] [ng] warns: don't report possible issues
From: |
Stefano Lattarini |
Subject: |
Re: [Automake-NG] [PATCH 12/17] [ng] warns: don't report possible issues with '_DEPENDENCIES' variables |
Date: |
Tue, 22 May 2012 23:34:22 +0200 |
Hi Akim.
On 05/22/2012 11:21 PM, Akim Demaille wrote:
>
> Le 22 mai 2012 à 22:50, Stefano Lattarini a écrit :
>
>> +* Automake-NG is less smart than mainline Automake in detecting some kind
>> + of possible typos or suspicious usages at automake runtime. This is due
>> + to the fact that more processing and logic takes place in the generated
>> + Makefiles rather than in the automake script, so that the latter has
>> + access to less context and information.
>
> You should explain why this is good.
>
It is *not* good; it is a trade-off. A hopefully temporary trade-off, since
this limitation can eventually be lifted once we've moved enough logic from
the automake scripts into the generated Makefiles.
Hmmm... but now that I think about it, in this case at least, we could move
such logic right away, moving the checks from the 'check_typos' function into
a makefile fragment which, using the $(.VARIABLES) special variable, looks for
DEPENDENCIES variables missing a proper corresponding entry in PROGRAMS (and
LIBRARIES and ...) This could be done as a follow-up on the top of this patch,
and then merged back into ng/master. WDYT?
Regards,
Stefano
- [Automake-NG] [PATCH 08/17] [ng] check: warn about invalid TEST_EXTENSIONS at make runtime, (continued)
[Automake-NG] [PATCH 10/17] [ng] am: new make variable '$(am__handle_exxext)', Stefano Lattarini, 2012/05/22
[Automake-NG] [PATCH 13/17] [ng] check: logic to define *LOG_DRIVER vars moved to generated Makefiles, Stefano Lattarini, 2012/05/22
[Automake-NG] [PATCH 14/17] [ng] check: be laxer in accepted $(TEST_EXTENSIONS), Stefano Lattarini, 2012/05/22
[Automake-NG] [PATCH 16/17] [ng] check: support conditional $(TEST_EXTENSIONS), Stefano Lattarini, 2012/05/22
[Automake-NG] [PATCH 17/17] [ng] cosmetics: improve comments and spacing in 'parallel-tests.am', Stefano Lattarini, 2012/05/22
[Automake-NG] [PATCH 15/17] [ng] check: accept dot-less entries in $(TEST_EXTENSIONS), Stefano Lattarini, 2012/05/22