[Top][All Lists]
[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
[Automake-NG] [PATCH 17/17] [ng] cosmetics: improve comments and spacing
From: |
Stefano Lattarini |
Subject: |
[Automake-NG] [PATCH 17/17] [ng] cosmetics: improve comments and spacing in 'parallel-tests.am' |
Date: |
Tue, 22 May 2012 22:50:58 +0200 |
* lib/am/parallel-tests.am: Fix some comment typos and missing
capitalization; improve clarity through more use of vertical
spacing; add a coupe of explicative comments.
Signed-off-by: Stefano Lattarini <address@hidden>
---
lib/am/parallel-tests.am | 14 ++++++++++----
1 file changed, 10 insertions(+), 4 deletions(-)
diff --git a/lib/am/parallel-tests.am b/lib/am/parallel-tests.am
index 1d08687..8121895 100644
--- a/lib/am/parallel-tests.am
+++ b/lib/am/parallel-tests.am
@@ -63,28 +63,34 @@ am__runtest = \
am__tpfx = $(if $(strip $1),$(call am__toupper,$(strip $(1))_))
!define am__handle_per_suffix_test
+!
+## FIXME: This will pick up the default from the environment; are we sure
+## FIXME: we want that?
!$$(call am__tpfx,$1)LOG_DRIVER ?= $(SHELL) $(am__config_aux_dir)/test-driver
+!
!%.log %.trs: %$(if $1,.$1) $$($$(call am__tpfx,$1)LOG_DEPENDENCIES)
! @$$(call am__runtest,$$(call am__tpfx,$1))
+!
!ifeq ($(am__handle_exeext),yes)
!ifdef EXEEXT
!%.log %.trs: %$(if $1,.$1)$(EXEEXT) $$($$(call am__tpfx,$1)LOG_DEPENDENCIES)
! @$$(call am__runtest,$$(call am__tpfx,$1))
!endif # defined EXEEXT
!endif # am__handle_exeext = yes
-!endef
!
-## FIXME: this will pick up the default from the environment; are we sure
+!endef # am__handle_per_suffix_test
+!
+## FIXME: This will pick up the default from the environment; are we sure
## FIXME: we want that?
!TEST_EXTENSIONS ?= .test
-## FIXME: it would be nice to break these on multiple lines. Unfortnately,
+## FIXME: It would be nice to break these on multiple lines. Unfortunately,
## FIXME: our '!' is not yet smart enough to handle that :-(
!$(foreach am__e,$(am__dotless_test_extensions),$(eval $(call
am__handle_per_suffix_test,$(am__e))))
## It is *imperative* that the "empty" suffix goes last. Otherwise, a
## declaration like "TESTS = all.test" would cause GNU make to mistakenly
## try to build the 'all.log' and 'all.trs' files from a non-existent
## 'all' program (because the Makefile contains an explicit 'all' target,
-## albeith .PHONY), rather than from the 'all.test' script, thus causing
+## albeit .PHONY), rather than from the 'all.test' script, thus causing
## all sort of mishaps and confusion.
!$(eval $(call am__handle_per_suffix_test))
--
1.7.9.5
- Re: [Automake-NG] [PATCH 12/17] [ng] warns: don't report possible issues with '_DEPENDENCIES' variables, (continued)
[Automake-NG] [PATCH 13/17] [ng] check: logic to define *LOG_DRIVER vars moved to generated Makefiles, Stefano Lattarini, 2012/05/22
[Automake-NG] [PATCH 14/17] [ng] check: be laxer in accepted $(TEST_EXTENSIONS), Stefano Lattarini, 2012/05/22
[Automake-NG] [PATCH 16/17] [ng] check: support conditional $(TEST_EXTENSIONS), Stefano Lattarini, 2012/05/22
[Automake-NG] [PATCH 17/17] [ng] cosmetics: improve comments and spacing in 'parallel-tests.am',
Stefano Lattarini <=
[Automake-NG] [PATCH 15/17] [ng] check: accept dot-less entries in $(TEST_EXTENSIONS), Stefano Lattarini, 2012/05/22
- Re: [Automake-NG] [PATCH 15/17] [ng] check: accept dot-less entries in $(TEST_EXTENSIONS), Akim Demaille, 2012/05/22
- Re: [Automake-NG] [PATCH 15/17] [ng] check: accept dot-less entries in $(TEST_EXTENSIONS), Stefano Lattarini, 2012/05/22
- [Automake-NG] [PATCH 15/17] [ng] check: warn about dot-less $(TEST_EXTENSIONS) at make runtime, Stefano Lattarini, 2012/05/22
- Re: [Automake-NG] [PATCH 15/17] [ng] check: warn about dot-less $(TEST_EXTENSIONS) at make runtime, Akim Demaille, 2012/05/23
- [Automake-NG] A new TODO file for Automake-NG? (was: Re: [PATCH 15/17] [ng] check: warn about dot-less $(TEST_EXTENSIONS) at make runtime), Stefano Lattarini, 2012/05/23
Re: [Automake-NG] [PATCH 15/17] [ng] check: accept dot-less entries in $(TEST_EXTENSIONS), Akim Demaille, 2012/05/23
[Automake-NG] [PATCH 18/17] [ng] coverage: parallel-tests and dynamic $(TEST_EXTENSIONS) content, Stefano Lattarini, 2012/05/22
[Automake-NG] [PATCH 19/17] [ng] doc: update w.r.t. recent changes in testsuite harnesses (TESTS-based), Stefano Lattarini, 2012/05/23