[Top][All Lists]
[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
[Automake-NG] A new TODO file for Automake-NG? (was: Re: [PATCH 15/17] [
From: |
Stefano Lattarini |
Subject: |
[Automake-NG] A new TODO file for Automake-NG? (was: Re: [PATCH 15/17] [ng] check: warn about dot-less $(TEST_EXTENSIONS) at make runtime) |
Date: |
Wed, 23 May 2012 09:52:04 +0200 |
On 05/23/2012 09:25 AM, Akim Demaille wrote:
>
> Le 23 mai 2012 à 00:34, Stefano Lattarini a écrit :
>
>> * lib/am/parallel-tests.am: Analyze the $(TEST_EXTENSIONS) contents at
>> make runtime, instead of relying on the '%INVALID_TEST_EXTENSIONS%'
>> transform once passed in by automake. Do any necessary error reporting
>> with the help of ...
>> (am__maybe_invalid_test_extensions): ... this new function.
>> * automake.in (is_valid_test_extension): Delete.
>> (handle_tests): Don't call that anymore. Simplify accordingly. Rely
>> on code in parallel-tests.am to report the proper errors at runtime.
>> * t/test-extensions.sh: Moved ...
>> * t/test-extensions-invalid.sh: ... to this, nd updated.
>> * Makefile.am (XFAIL_TESTS): Drop 'test-extensions.sh'.
>>
>> Signed-off-by: Stefano Lattarini <address@hidden>
>> ---
>>
>> Here is the patch to be substituted to the old one "[ng] check: accept
>> dot-less entries in $(TEST_EXTENSIONS)".
>>
>> OK?
>
> Fine!
>
Thanks!
>> - INVALID_TEST_EXTENSIONS => "@invalid_test_suffixes");
>
> This is an example of what I'd like to see removed
> from Automake: redundant vocabulary.
>
Which, in this particular case, I've been guilty of introducing I
fear (back in mainline Automake).
> Chose between "suffix" and "extension", and stick to it. Of course
> I am more troubled when this arises in the API than in automake's
> code, yet squashing this everywhere would be nice imho.
>
Given the increasing number of long-term "philosophic" suggestion
you are making (which I do appreciate, because they give direction
and purpose to the Automake-NG development), I think it would be
worthwhile (and more tolerant to faulty memory ;-) to start listing
them in a new TODO file; I'd suggest naming it "NG-TODO", and
placing it in the top-level source directory.
Do you still have commit access to the Automake repository? If yes,
could you create such a file (on the 'ng/master' branch) and start
filling it up with the long-term suggestions/wishlists you've come
up so far?
Thanks,
Stefano
[Automake-NG] [PATCH 18/17] [ng] coverage: parallel-tests and dynamic $(TEST_EXTENSIONS) content, Stefano Lattarini, 2012/05/22
[Automake-NG] [PATCH 19/17] [ng] doc: update w.r.t. recent changes in testsuite harnesses (TESTS-based), Stefano Lattarini, 2012/05/23
[Automake-NG] [PATCH 20/17] [ng] news: update w.r.t. recent changes in testsuite harnesses (TESTS based), Stefano Lattarini, 2012/05/23