[Top][All Lists]
[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [Automake-NG] [PATCH 10/26] [ng] texi: reduce code duplication in ou
From: |
Akim Demaille |
Subject: |
Re: [Automake-NG] [PATCH 10/26] [ng] texi: reduce code duplication in output Makefile |
Date: |
Sun, 17 Jun 2012 08:56:05 +0200 |
Le 16 juin 2012 à 23:29, Stefano Lattarini a écrit :
> diff --git a/lib/am/texibuild.am b/lib/am/texibuild.am
> index a81bcf2..09905d5 100644
> --- a/lib/am/texibuild.am
> +++ b/lib/am/texibuild.am
> @@ -89,14 +89,15 @@ define am__texibuild_html
> fi
> endef
>
> -%.info: %.%TEXI-SUFFIX%
> - $(call am__texibuild_info,$(am__info_insrc))
> -
> -%.dvi: %.%TEXI-SUFFIX%
> - $(call am__texibuild_dvi_or_pdf,%AM_V_TEXI2DVI%,$(TEXI2DVI))
> -
> -%.pdf: %.%TEXI-SUFFIX%
> - $(call am__texibuild_dvi_or_pdf,%AM_V_TEXI2PDF%,$(TEXI2PDF))
> +define am__texi_rules_for_suffix
> +%.info: %.$1
> + $$(call am__texibuild_info,$$(am__info_insrc))
> +%.dvi: %.$1
> + $$(call am__texibuild_dvi_or_pdf,$$(AM_V_TEXI2DVI),$$(TEXI2DVI))
> +%.pdf: %.$1
> + $$(call am__texibuild_dvi_or_pdf,$$(AM_V_TEXI2PDF),$$(TEXI2PDF))
> +%.html: %.$1
> + $$(am__texibuild_html)
> +endef
>
> -%.html: %.%TEXI-SUFFIX%
> - $(am__texibuild_html)
> +$(foreach s,%TEXI-SUFFIXES%,$(eval $(call am__texi_rules_for_suffix,$s)))
This kind of changes will make using "grep" in the Makefile, to find
the recipes, less obvious. I think I prefer the previous approach.
- Re: [Automake-NG] [PATCH 08/26] [ng] texi: reduce code duplication in texibuild.am, (continued)
[Automake-NG] [PATCH 09/26] [ng] texi: refactoring in texibuild.am, Stefano Lattarini, 2012/06/16
[Automake-NG] [PATCH 10/26] [ng] texi: reduce code duplication in output Makefile, Stefano Lattarini, 2012/06/16
- Re: [Automake-NG] [PATCH 10/26] [ng] texi: reduce code duplication in output Makefile,
Akim Demaille <=
[Automake-NG] [PATCH 11/26] [ng] texi: reorganize '.am' fragments a bit, Stefano Lattarini, 2012/06/16
[Automake-NG] [PATCH 12/26] [ng] texi: reorganize '.am' fragments even more, Stefano Lattarini, 2012/06/16
[Automake-NG] [PATCH 13/26] [ng] texi: drop transforms when reading texibuild.am, Stefano Lattarini, 2012/06/16
[Automake-NG] [PATCH 14/26] [ng] texi: adjust names of vars used for silent rules support, Stefano Lattarini, 2012/06/16