[Top][All Lists]
[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: Patch 1 of 4: Better DOS path support
From: |
Akim Demaille |
Subject: |
Re: Patch 1 of 4: Better DOS path support |
Date: |
19 Feb 2001 11:11:26 +0100 |
User-agent: |
Gnus/5.0808 (Gnus v5.8.8) XEmacs/21.1 (Cuyahoga Valley) |
"Tim Van Holder" <address@hidden> writes:
> - /* | [A-Za-z]:*) ;;
> - */*) prog="`pwd`/$prog" ;;
> + [/\\]* | [A-Za-z]:[/\\]*) ;;
> + *[\\/]*) prog="`pwd`/$prog" ;;
> @@ -11,7 +11,7 @@
> # Always use an absolute srcdir. Otherwise symlinks made in subdirs
> # of the test dir just won't work.
> case "$srcdir" in
> - /*)
> + [\\/]* | ?:[\\/]*)
> ;;
>
> *)
My opinion is that there should be exactly one case pattern used
everywhere. I can see they were different before your patch, but I'd
suggest that your patch makes them uniform. And of course, the same
as promoted by autoconf.texi :)
> - ln -s ../"$input" . > /dev/null 2>&1 || ln ../"$input" . > /dev/null
> 2>&1 || cp ../"$input" .
Please, don't cut and paste, your patches are not applicable.
> + if test -n "$COMSPEC$ComSpec"; then
> + # DOSish system: don't try ln -s; it is most likely broken.
> + ln ../"$input" . > /dev/null 2>&1 || cp ../"$input" .
> + else
> + ln -s ../"$input" . > /dev/null 2>&1 || ln ../"$input" . > /dev/null
> 2>&1 || cp ../"$input" .
> + fi
> ;;
Hm, what was wrong? I mean, ln -s was exit 0, but actually failed?
- Patch 1 of 4: Better DOS path support, Tim Van Holder, 2001/02/10
- Re: Patch 1 of 4: Better DOS path support,
Akim Demaille <=
- RE: Patch 1 of 4: Better DOS path support, Tim Van Holder, 2001/02/19
- Re: Patch 1 of 4: Better DOS path support, Akim Demaille, 2001/02/20
- Manual additions (DOS issues), Tim Van Holder, 2001/02/20
- Re: Manual additions (DOS issues), Akim Demaille, 2001/02/21
- RE: Manual additions (DOS issues), Tim Van Holder, 2001/02/21
- RE: Manual additions (DOS issues), Tim Van Holder, 2001/02/21
- Re: Manual additions (DOS issues), Akim Demaille, 2001/02/22
- Re: Manual additions (DOS issues), Alexandre Oliva, 2001/02/22
- RE: Manual additions (DOS issues), Tim Van Holder, 2001/02/22