avrdude-dev
[Top][All Lists]
Advanced

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

[avrdude-dev] [patch #6543] serial-over-tcpip support for cygwin


From: Joerg Wunsch
Subject: [avrdude-dev] [patch #6543] serial-over-tcpip support for cygwin
Date: Tue, 17 Feb 2009 13:15:27 +0000
User-agent: Mozilla/5.0 (X11; U; Linux i686 (x86_64); en-US; rv:1.8.1.19) Gecko/20081217 SeaMonkey/1.1.14

Update of patch #6543 (project avrdude):

                  Status:                    None => Postponed              
             Assigned to:                    None => joerg_wunsch           

    _______________________________________________________

Follow-up Comment #1:

Besides mixing some unrelated (and meanwhile obsolete) patches
into the actual patch, there is one fundamental issue with
this patch: it removes the -mno-cygwin option from CFLAGS
for Cygwin builds.  However, -mno-cygwin has been explicitly
added to allow Win32-API-only builds (i.e. MinGW32 builds)
even when building under Cygwin, so no dependency to
cygwin1.dll is required.  As far as I know, this feature is
crucial to the way the WinAVR build environment works.

For that reason, adding a native Cygwin build should be
implemented as a configure option (like --enable-native-cygwin),
defaulting to the current way (i.e. --disable-native-cygwin).
This is an acceptance requirement.

Also, as Cygwin basically offers a Posix-compliant API, I
think it would be better to massage the build system so
native Cygwin builds just go ahead, and use ser_posix.c
directly, rather than duplicating much of its functionality
in ser_win32.c.  This is not a requirement, but a wish that
allows for easier maintenance.

I'd kindly ask to submit a modified patch.

    _______________________________________________________

Reply to this item at:

  <http://savannah.nongnu.org/patch/?6543>

_______________________________________________
  Message sent via/by Savannah
  http://savannah.nongnu.org/





reply via email to

[Prev in Thread] Current Thread [Next in Thread]