[Top][All Lists]
[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
RE: [avrdude-dev] [patch #6543] serial-over-tcpip support for cygwin
From: |
Weddington, Eric |
Subject: |
RE: [avrdude-dev] [patch #6543] serial-over-tcpip support for cygwin |
Date: |
Tue, 17 Feb 2009 06:29:37 -0700 |
> -----Original Message-----
> From:
> address@hidden
> [mailto:address@hidden
> rg] On Behalf Of Joerg Wunsch
> Sent: Tuesday, February 17, 2009 6:15 AM
> To: Joerg Wunsch; Janos Sallai; address@hidden
> Subject: [avrdude-dev] [patch #6543] serial-over-tcpip
> support for cygwin
>
>
> Update of patch #6543 (project avrdude):
>
> Status: None =>
> Postponed
> Assigned to: None =>
> joerg_wunsch
>
> _______________________________________________________
>
> Follow-up Comment #1:
>
> Besides mixing some unrelated (and meanwhile obsolete) patches
> into the actual patch, there is one fundamental issue with
> this patch: it removes the -mno-cygwin option from CFLAGS
> for Cygwin builds. However, -mno-cygwin has been explicitly
> added to allow Win32-API-only builds (i.e. MinGW32 builds)
> even when building under Cygwin, so no dependency to
> cygwin1.dll is required. As far as I know, this feature is
> crucial to the way the WinAVR build environment works.
>
> For that reason, adding a native Cygwin build should be
> implemented as a configure option (like --enable-native-cygwin),
> defaulting to the current way (i.e. --disable-native-cygwin).
> This is an acceptance requirement.
>
> Also, as Cygwin basically offers a Posix-compliant API, I
> think it would be better to massage the build system so
> native Cygwin builds just go ahead, and use ser_posix.c
> directly, rather than duplicating much of its functionality
> in ser_win32.c. This is not a requirement, but a wish that
> allows for easier maintenance.
>
> I'd kindly ask to submit a modified patch.
It would be nice if any new functionality could also be ported to mingw/windows
builds of avrdude. I would think that it's best to have the same functionality
across all ports.