bbdb-user
[Top][All Lists]
Advanced

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

typos in comments and doc strings


From: Stephen J. Turnbull
Subject: typos in comments and doc strings
Date: Thu, 07 Jul 2022 13:07:12 +0900

Sam Steingold writes:

 > There are quite a few typos in comments and doc strings in bbdb code.
 > Most can be found by `ispell-comments-and-strings'.

But they need to be hand-checked.  This diff should not be applied as
is IMO.

 > -Noninteractively, this may be used as an element of 
 > `bbdb-notice-record-hook'
 > +Non-interactively, this may be used as an element of 
 > `bbdb-notice-record-hook'

This hypenation (and the similar hyphenation of "subexpression") are
excessively pedantic, and not worth the code churn.  I'm pretty sure
that "noninteractive" now implies a lot more than "not interactive" to
most GNU users (see, for example bash (1) on noninteractive shells).
Under the usual rules for removal of hyphens, I'd say this qualifies.
"Subexpression" is a little more doubtful to me, but it's a lot of
churn.  YMMV, of course, and it's up to Roland, this is all IMO for
his information.

 > @@ -724,7 +724,7 @@ DATE must be in yyyy-mm-dd format."
 >  ;; XXX this needs expansion to handle international prefixes properly
 >  ;; i.e. +353-number without discarding the +353 part. Problem being
 >  ;; that this will necessitate yet another change in the database
 > -;; format for people who are using north american numbers.
 > +;; format for people who are using north American numbers.

"North American".

Steve




reply via email to

[Prev in Thread] Current Thread [Next in Thread]