[Top][All Lists]
[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [Beaver-devel] Patches
From: |
Timothy J. Warren |
Subject: |
Re: [Beaver-devel] Patches |
Date: |
Sun, 17 Aug 2003 12:45:43 -0400 |
On Sat, 16 Aug 2003 13:07:56 -0400
Michael Terry <address@hidden> wrote:
> Ok. Thank you very much for the submittal. I'll try to put in your
> patches this weekend.
>
> However, I wonder if ALT+n is being used by current window managers.
> Does anyone know of any that use those shortcuts?
>
> A couple minor nits: You change the 'modified' status of new files
> from modified to unmodified seemingly without reason (it is unrelated
> to the stated purpose of the patch). Also, you should free the
> variable 'shortcut_key' after allocating memory for it. Both these
> nits I'll fix on my own when I commit it, just FYI.
>
> -mt
I'm currently using fluxbox, which doesn't have any defaults for ALT+n.
Seeing some of the other discussion, it looks like there is talk of
moving to a Ctrl+Pg{Up,Down} to move between tabs. This is fine, but I
still like the ability to go directly to a specific tab.
As for changing the "modified" status of new files: the default behavior
of Beaver was to set a new file as modified, whether you had actually
made any changes or not. So, if you opened a blank document, then
closed it without making any changes, it asked you if you wanted to save
it. I didn't think that was "good" behavior, so I removed it. I'm
sorry I didn't mention it with the patch submission.
Lastly, you're right about not freeing the memory on "shortcut_key". I
haven't worked with C in a while, not used to doing my own memory
management! ;)
Thanks for the feedback,
Timothy J. Warren