Re: "make check-TEST" lossage on FreeBSD make (+ untested patch)

[Mark D. Baushke]

-----BEGIN PGP SIGNED MESSAGE-----
Hash: SHA1

Alexandre Duret-Lutz <address@hidden> writes:

> My feeling is that `cp -pR' is not able to copy read-only trees
> on your system.  After it has copied the top-level directory,
> and cannot create its subdirectories because the top-level
> directory is read-only.
> 
> Could you try the following commands?
> 
...output elided...

> 
> If `cp -pR' didn't work, we have found the problem.  

Yes, that is indeed the problem.

> Otherwise please apply the following patch and rerun this test case,
> so we can see exactly which command complains.
> 
> --- lib/am/distdir.am 18 Apr 2004 18:36:52 -0000      1.52.2.4
> +++ lib/am/distdir.am 14 May 2004 07:16:25 -0000
> @@ -59,6 +59,7 @@
>  ##
>       @srcdirstrip=`echo "$(srcdir)" | sed 's|.|.|g'`; \
>       topsrcdirstrip=`echo "$(top_srcdir)" | sed 's|.|.|g'`; \
> +     set -x; \
>       list='$(DISTFILES)'; for file in $$list; do \
>  ##
>  ## Yet another hack to support SUN make.
> -- 
> Alexandre Duret-Lutz

        -- Mark

% cat <<EOF > /tmp/test-destdir.sh
#!/bin/sh
cd /tmp
mkdir empty
cd empty
mkdir -p dir1/dir2
touch dir1/x dir1/dir2/x
chmod -R a-w dir1
ls -laR dir1
mkdir dest
cp -pR dir1 dest
ls -laR dest
EOF
% sh -x /tmp/test-distdir.sh
+ cd /tmp
+ mkdir empty
+ cd empty
+ mkdir -p dir1/dir2
+ touch dir1/x dir1/dir2/x
+ chmod -R a-w dir1
+ ls -laR dir1
total 6
dr-xr-xr-x  3 mdb  wheel  512 May 14 00:45 .
drwxr-xr-x  3 mdb  wheel  512 May 14 00:45 ..
dr-xr-xr-x  2 mdb  wheel  512 May 14 00:45 dir2
- -r--r--r--  1 mdb  wheel    0 May 14 00:45 x

dir1/dir2:
total 4
dr-xr-xr-x  2 mdb  wheel  512 May 14 00:45 .
dr-xr-xr-x  3 mdb  wheel  512 May 14 00:45 ..
- -r--r--r--  1 mdb  wheel    0 May 14 00:45 x
+ mkdir dest
+ cp -pR dir1 dest
cp: dest/dir1/dir2: Permission denied
+ ls -laR dest
total 6
drwxr-xr-x  3 mdb  wheel  512 May 14 00:45 .
drwxr-xr-x  4 mdb  wheel  512 May 14 00:45 ..
dr-xr-xr-x  2 mdb  wheel  512 May 14 00:45 dir1

dest/dir1:
total 4
dr-xr-xr-x  2 mdb  wheel  512 May 14 00:45 .
drwxr-xr-x  3 mdb  wheel  512 May 14 00:45 ..
%
-----BEGIN PGP SIGNATURE-----
Version: GnuPG v1.2.3 (FreeBSD)

iD8DBQFApHnA3x41pRYZE/gRAnx7AJ0QEOElsTxMzxLZW3p1v0AaMaDaCQCggZKO
eE7+AI3V9kieVetxe6H2Of8=
=HID5
-----END PGP SIGNATURE-----