[Bug binutils/29993] objcopy --merge-notes slow for large .so with many annobin notes

[nickc at redhat dot com]

https://sourceware.org/bugzilla/show_bug.cgi?id=29993

--- Comment #6 from Nick Clifton <nickc at redhat dot com> ---
(In reply to Frank Ch. Eigler from comment #5)
Hi Frank,

Yes - I am afraid that the watermark protocol document is a bit out of date,
and its rules for note merging do need to be updated.

> So, as for a more efficient merging algorithm, I would explore something
> like this:

Your idea is excellent.  However before I go down that route - and probably
break building lots of packages by introducing new bugs - would you care to try
out a scratch build of the binutils which has a tweaked merge algorithm ?

   https://koji.fedoraproject.org/koji/taskinfo?taskID=96203568

I just added a variable to keep track of the last non-deleted note, so that the
backwards search could start from there, rather than the previous note.  With
this patch applied I found that merging libxul.so went down from 10.5 minutes
to 5 minutes on my local machine.  Not an order of magnitude improvement I
know, but would it be enough for you ?  

I am hesitant to rewrite the algorithm entirely because if I get it wrong I am
likely to break the building of other packages - either by corrupting the notes
so that annocheck then complains, or breaking the merge process so that the
rpms do not build or something else.

Cheers
  Nick

-- 
You are receiving this mail because:
You are on the CC list for the bug.